Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

PSS: Validate the backend or state store configurations described by plan files#37948

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Draft
SarahFrench wants to merge16 commits intopss/update-how-operations-use-backend-config-state
base:pss/update-how-operations-use-backend-config-state
Choose a base branch
Loading
frompss/validate-backend-state-store-config-in-plans

Conversation

@SarahFrench
Copy link
Member

@SarahFrenchSarahFrench commentedNov 28, 2025
edited
Loading

This PR is blocked by review of#37946,#37956, and#37957

Follows#37248

This PR adds validation to stop Terraform writing or using a planfile that has incomplete descriptions of the backend or state store configuration.

Target Release

N/A

Rollback Plan

  • If a change needs to be reverted, we will roll out an update to the code within 7 days.

Changes to Security Controls

Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.

CHANGELOG entry

  • This change is user-facing and I added a changelog entry.
  • This change is not user-facing.

@SarahFrenchSarahFrench added the no-changelog-neededAdd this to your PR if the change does not require a changelog entry labelNov 28, 2025
@github-actions

This comment was marked as outdated.

@SarahFrenchSarahFrenchforce-pushed thepss/update-how-operations-use-backend-config-state branch from94d4233 to9a018e9CompareNovember 28, 2025 12:25
@SarahFrenchSarahFrenchforce-pushed thepss/update-how-operations-use-backend-config-state branch from9a018e9 tod16ebe6CompareNovember 28, 2025 12:47
@SarahFrenchSarahFrenchforce-pushed thepss/validate-backend-state-store-config-in-plans branch fromb44b360 toc6922efCompareNovember 28, 2025 12:55
@SarahFrenchSarahFrenchforce-pushed thepss/update-how-operations-use-backend-config-state branch fromd16ebe6 tof795158CompareNovember 28, 2025 16:16
This helps with navigating ambiguity around the word backend. The new name should indicate that the value represents a `backend` block, not a more general interpretation of what a backend is.
…to a lack of data. Don't change it if pluggable state storage is in use.
…ly isn't valid for `stateStoreConfigState` to be nilI'm about 90% sure that backendConfigState being nil is ok <_<
… file with the expected state_store configuration data
…ng it to prepare a Local backend that uses the state store
…quired providers, if PSS is in use.See the code comment added in this commit. This addition does not impact an apply command as the missing provider will be detected before this code is executed. However I'm making this change so that the method is still accurate is being able to return a complete list of providers needed by the plan.
…or state store config when getting a backend from a planfile
…Backend, so the planfile's Backend struct isn't flagged as empty.
…f a backend or state store is completeThe alternative approach would be to change the existing `Backend` field in the `Plan` struct to be a pointer. I'm open to either option, but the approach of using an `Empty` method matches existing work in the `workdir` package when inspecting the backend state file, and that seems a similar use-case to inspecting the plan file.
…e store is complete when reading or writing a plan file
@SarahFrenchSarahFrenchforce-pushed thepss/validate-backend-state-store-config-in-plans branch fromc6922ef toe3f20b8CompareDecember 2, 2025 13:37
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

no-changelog-neededAdd this to your PR if the change does not require a changelog entry

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@SarahFrench

[8]ページ先頭

©2009-2025 Movatter.jp