- Notifications
You must be signed in to change notification settings - Fork10.1k
Update how operations use backend config state in context of PSS#37248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Draft
SarahFrench wants to merge13 commits intomainChoose a base branch frompss/update-how-operations-use-backend-config-state
base:main
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
+675 −200
Draft
Changes from1 commit
Commits
Show all changes
13 commits Select commitHold shift + click to select a range
e5701a9
Implement `ForPlan` method on `StateStoreConfigState`, add `Planner` …
SarahFrenchfd7182a
Rename `ForPlan` method to `Plan`
SarahFrenchee6e9da
Allow plan files to contain information about state stores
SarahFrench1bb87e8
Add code needed for representing a state store in the Plan struct, wh…
SarahFrench9e076d8
Add ability to read/write either a backend or state store's data in a…
SarahFrench44ce79b
Update plan's `ProviderAddrs` method to include the provider used for…
SarahFrencha2acc33
Split interfaces
SarahFrench5255d9d
Merge branch 'main' into pss/store-pss-in-planfile
SarahFrench2479cdc
WIP
SarahFrench5b825b2
WIP - allowing apply operation to use plan file content about backend…
SarahFrench19ede22
Fix - it is valid to not have a backend config in the plan file
SarahFrench571bffc
Update test following change to BackendForLocalPlan argument
SarahFrencha5a439f
Fix code consistency issue
SarahFrenchFile filter
Filter by extension
Conversations
Failed to load comments.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Jump to
Jump to file
Failed to load files.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Diff view
Diff view
Rename
ForPlan
method toPlan
- Loading branch information
Uh oh!
There was an error while loading.Please reload this page.
commitfd7182af667565356d1c6e7967a1cad3dad53bd7
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -17,5 +17,5 @@ type ConfigState[T any] interface { | ||
} | ||
type Planner[T any] interface { | ||
Plan(*configschema.Block, string) (*T, error) | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.