Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

fix implicitly nullable via default value null for PHP-8.4#85

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
davedevelopment merged 1 commit intohamcrest:masterfromtxddev:php84-support
Apr 29, 2025

Conversation

@txdFabio
Copy link
Contributor

use of explicit nullable type for php-8.4 compatibility

Copy link
Member

@aik099aik099 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This change breaks support for PHP versions below PHP 7.2.

@txdFabio
Copy link
ContributorAuthor

you're right... can we change composer requirements to supporto only newer versions? Do I have to submit another PR?

@aik099
Copy link
Member

@davedevelopment, should we raise the minimum supported PHP version of the library (e.g., to PHP 7.2) to allow changes like the one proposed in this PR to work on PHP 8.4?

PNardman reacted with thumbs up emoji

@PNardman
Copy link

  • 1 already waiting for this. 👍

@PNardman
Copy link

Any update on when this could be merged? Updated?

@aik099
Copy link
Member

Any update on when this could be merged? Updated?

@PNardma , no updates.

@davedevelopment , ping.

@PNardman
Copy link

Still no update. 😢

@aik099
Copy link
Member

Still no update. 😢

@PNardman , Please try contacting@davedevelopment and other library maintainers by other communication channels (e.g. e-mail, twitter, etc.).

@davedevelopment
Copy link
Member

I'm sorry, I've been away from Hamcrest for some time and completely forgot about my responsibilities here. Generally, I'd say yes, 7.2 is very old and they can always version pin.

@aik099
Copy link
Member

@davedevelopment , then here are the next steps:

  1. create another PR that will set a minimum compatible PHP version to PHP 7.2 (or even PHP 7.4)
  2. make a release
  3. rebase & merge this PR

.

@davedevelopment
Copy link
Member

Opened#87

@davedevelopmentdavedevelopment merged commitb1093f2 intohamcrest:masterApr 29, 2025
4 of 14 checks passed
@txdFabio
Copy link
ContributorAuthor

I've seen the 2.1.0 release which remove older php constraints, but - while it's merged to master - it doesn't include the implicit nullable fix, is there anything else we need to do?

@davedevelopment
Copy link
Member

Generally I'd avoid tagging for every fix, but go on then...

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@aik099aik099aik099 requested changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@txdFabio@aik099@PNardman@davedevelopment

[8]ページ先頭

©2009-2025 Movatter.jp