- Notifications
You must be signed in to change notification settings - Fork46
fix implicitly nullable via default value null for PHP-8.4#85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This change breaks support for PHP versions below PHP 7.2.
you're right... can we change composer requirements to supporto only newer versions? Do I have to submit another PR? |
@davedevelopment, should we raise the minimum supported PHP version of the library (e.g., to PHP 7.2) to allow changes like the one proposed in this PR to work on PHP 8.4? |
PNardman commentedFeb 18, 2025
|
PNardman commentedMar 5, 2025
Any update on when this could be merged? Updated? |
@PNardma , no updates. @davedevelopment , ping. |
PNardman commentedApr 7, 2025
Still no update. 😢 |
@PNardman , Please try contacting@davedevelopment and other library maintainers by other communication channels (e.g. e-mail, twitter, etc.). |
I'm sorry, I've been away from Hamcrest for some time and completely forgot about my responsibilities here. Generally, I'd say yes, 7.2 is very old and they can always version pin. |
@davedevelopment , then here are the next steps:
. |
Opened#87 |
b1093f2 intohamcrest:masterUh oh!
There was an error while loading.Please reload this page.
I've seen the 2.1.0 release which remove older php constraints, but - while it's merged to master - it doesn't include the implicit nullable fix, is there anything else we need to do? |
Generally I'd avoid tagging for every fix, but go on then... |
use of explicit nullable type for php-8.4 compatibility