Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork1.5k
Refactor last commit retrieval to use a non deprecated method#4898
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Pull Request Overview
This PR refactors the code to consolidate duplicate logic for fetching repository commit information. The main change replaces direct calls torepository_object.set_last_commit() with a new methodasync_set_last_commits() that uses the GitHub REST API to fetch branch information.
- Introduces a new method
async_set_last_commits()that fetches the last commit SHA from the repository's default branch - Replaces two instances of duplicated commit-fetching code with calls to the new method
- Changes the implementation from using
repository_object.set_last_commit()to directly calling the GitHub API
💡Add Copilot custom instructions for smarter, more guided reviews.Learn how to get started.
Uh oh!
There was an error while loading.Please reload this page.
The entire repository_object is deprecated in aiogithubapi; this is a small step in getting rid of it.