Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork1.5k
Fix download counter to use correct asset for repositories with multiple release assets#4693
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Draft
Copilot wants to merge2 commits intomainChoose a base branch fromcopilot/fix-4438
base:main
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
…ple release assetsCo-authored-by: ludeeus <15093472+ludeeus@users.noreply.github.com>
CopilotAI changed the title[WIP] Download counter shows wrong valueFix download counter to use correct asset for repositories with multiple release assetsJul 6, 2025
Copilot finished work on behalf ofludeeusJuly 6, 2025 07:36
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
The download counter was showing incorrect values for repositories with multiple release assets. The issue occurred because HACS always used the download count from the first asset in the release instead of the asset specified by the
filenamefield in the repository manifest (hacs.yaml).Problem
When a repository has multiple release assets, the download counter would display the download count from the first asset rather than the correct asset. For example, the
mbapi2020component was showing ~190 downloads (from the first asset) instead of ~4000 downloads (from the correctmbapi2020.zipasset).Root Cause
In
custom_components/hacs/repositories/base.py, the code usednext(iter(assets)).download_countwhich always retrieves the first asset from the assets list, regardless of which asset is actually being used for the repository.Solution
Modified the download counting logic to:
self.data.file_name(the filename specified in the repository manifest)file_nameis None (preserving existing behavior)Changes Made
custom_components/hacs/repositories/base.py: Updated download counting logic in thecommon_update_datamethodtests/repositories/test_download_counter.py: Added comprehensive test coverage for all scenariosValidation
The fix has been validated to:
Fixes#4438.
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Clickhere to start the survey.