Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

ui: fix crash of live cam on arch-linux#1602

Open
binarytrails wants to merge 2 commits intohacksider:mainfrom
binarytrails:main
Open

ui: fix crash of live cam on arch-linux#1602
binarytrails wants to merge 2 commits intohacksider:mainfrom
binarytrails:main

Conversation

@binarytrails
Copy link

@binarytrailsbinarytrails commentedDec 7, 2025•
edited by sourcery-aibot
Loading

Ensure the dimensions are valid before attempting the resize operation

Summary by Sourcery

Bug Fixes:

  • Avoid crashes when fitting images by skipping resize if width or height are non-positive or non-integer, or if the image has zero dimensions.

Ensure the dimensions are valid before attempting the resize operation
@sourcery-ai
Copy link
Contributor

sourcery-aibot commentedDec 7, 2025•
edited
Loading

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Adds robust validation of target and computed dimensions in fit_image_to_size to prevent invalid resize operations (e.g., zero or negative sizes) that can crash the live cam on some systems.

File-Level Changes

ChangeDetailsFiles
Harden image resizing logic to guard against invalid input and computed dimensions before calling cv2.resize.
  • Return the original image if width or height are not integers or are non-positive values.
  • Return the original image if the source image has zero height or width.
  • After computing the scaled size, verify both dimensions are positive before resizing, otherwise return the original image.
modules/ui.py

Possibly linked issues

  • #failed when use cam live on laptop: PR adds dimension checks in fit_image_to_size to avoid invalid OpenCV resize causing the Arch Linux live cam crash.
Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment@sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with@sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write@sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write@sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment@sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment@sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment@sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment@sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access yourdashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Contributor

@sourcery-aisourcery-aibot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Hey there - I've reviewed your changes and they look great!

Prompt for AI Agents
Please address the comments from this code review:##Individual Comments###Comment 1<location>`modules/ui.py:769` </location><code_context> def fit_image_to_size(image, width: int, height: int):     if width is None and height is None:         return image+    if not isinstance(width, int) or not isinstance(height, int) or width <= 0 or height <= 0:+   return image     h, w, _ = image.shape</code_context><issue_to_address>**suggestion:** The strict`int` type check may reject valid numeric types (e.g., NumPy integer scalars).This check will be`False` for types like`numpy.int32`, so calls with common integer-like dimensions will unexpectedly return the original image. Consider using`numbers.Integral` (or a similar numeric protocol) instead of`int`, or relying on the`<= 0` guard and handling any type errors at the resize call, so valid integer-like widths/heights are accepted.Suggested implementation:```pythondeffit_image_to_size(image,width:int,height:int):if widthisNoneand heightisNone:return imageifnotisinstance(width, numbers.Integral)ornotisinstance(height, numbers.Integral)or width<=0or height<=0:return image```Add`import numbers` (or`from numbers import Integral` and adjust the checks accordingly) near the top of`modules/ui.py`, alongside the other imports:- Option 1:-`import numbers`- keep`isinstance(width, numbers.Integral)` /`isinstance(height, numbers.Integral)`- Option 2:-`from numbers import Integral`- change the checks to`isinstance(width, Integral)` /`isinstance(height, Integral)`</issue_to_address>
Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@sourcery-aisourcery-ai[bot]sourcery-ai[bot] left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@binarytrails

Comments

[8]ページ先頭
©2009-2026 Movatter.jp