- Notifications
You must be signed in to change notification settings - Fork110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Fix a couple of issue experienced around headers#59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
…headers, including UPPERCASE and Mixed-CASE headers. The current matching implementation does not allow for this. This change allows you to mock this type of header, but setting the headers explicitly to the map, rather than through set.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While mocking a third party API, I came across issues where Headers would not match because the headers required were in Upper case.
This can be addressed in the http.Request by setting the map entries directly rather than having them sanitised when adding with http.RequestHeader.Add or http.Request.Header.Set.
The underlying code for the match already pulls the values from the map directly, but when the match is added, it uses Header.Set, meaning if I'm expecting a header like: "JANKY-UPPERCASE-HEADER" it will never match, because the matcher changes it to "Janky-Uppercase-Header".
This change allows this to be mocked as well. By setting the values to be matched explicitly to the Map when the Header Match is created.
This change also fixes issue#58