- Notifications
You must be signed in to change notification settings - Fork3
Ratings from RateMyProfessors.com#86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
…me. It still needs work because clicking an instructor still adds the class to the calendar.
…In fact, if RMP does not have a first initial, there won't be a match. For example GOODRICH, M. is not listed with a first initial on RMP.
…or. Added better error messages.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added the feature to view ratings from RateMyProfessors.com by clicking on the instructor's name. The problem is that I added the click event to the specific cell (td) which doesn't override the click event on row (tr). So needless to say, clicking on an instructor brings up their ratings AND adds the course. It would probably be best to remove the latter part to avoid the error message when a course is already added.
You can see the feature in action by visitinghttp://antplanner-fork.appspot.com