Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Add datadog certifier#2366

Open
robert-cronin wants to merge1 commit intoguacsec:main
base:main
Choose a base branch
Loading
fromrobert-cronin:feat/datadog-certifier

Conversation

robert-cronin
Copy link
Collaborator

@robert-croninrobert-cronin commentedDec 12, 2024
edited
Loading

Description of the PR

Fixes#2345

I am not sure if there is a need for a parser or attestation since were just ingesting CertifyBad for a particular pURL, but if there is a need to represent the source information in a predicate, I'd be happy to try and figure out how to add that in.

PR Checklist

  • All commits havea Developer Certificate of Origin (DCO) -- they are generated using-s flag togit commit.
  • All new changes are covered by tests
  • If GraphQL schema is changed,make generate has been run
  • If GraphQL schema is changed, GraphQL client updates/additions have been made
  • If OpenAPI spec is changed,make generate has been run
  • If ent schema is changed,make generate has been run
  • Ifcollectsub protobuf has been changed,make proto has been run
  • All CI checks are passing (tests and formatting)
  • All dependent PRs have already been merged

@funnelfiasco
Copy link
Contributor

As a general comment, I wonder if we want to call it something more specific than "DataDog"? "DataDog Malicious Packages DataSet" is unwieldy, but I'm concerned that there might be some future thing that pulls from DataDog proper and the name is already taken. I don't have any great ideas and this may not be a concern worth worrying about right now, but I wanted to raise it.

@robert-cronin
Copy link
CollaboratorAuthor

robert-cronin commentedDec 13, 2024
edited
Loading

As a general comment, I wonder if we want to call it something more specific than "DataDog"? "DataDog Malicious Packages DataSet" is unwieldy, but I'm concerned that there might be some future thing that pulls from DataDog proper and the name is already taken. I don't have any great ideas and this may not be a concern worth worrying about right now, but I wanted to raise it.

yeah, that is a solid point, if DataDog eventually spin out other datasets, I can see how that might cause some confusion. The data itself mostly comes fromGuardDog but I think not exclusively. Maybe we can go with something likedatadog-malware-dataset ordatadog-mspd but mspd is not a known acronym. The alternative isdatadog-malicious-software-packages-dataset but like you said that is a bit unwieldy.
Thedatadog-malware-dataset one sounds like the best compromise to me between clarity and brevity.

funnelfiasco reacted with thumbs up emoji

@pxp928
Copy link
Collaborator

Thanks@robert-cronin! Sorry for the delay. We will review this soon!

robert-cronin reacted with heart emoji

@robert-cronin
Copy link
CollaboratorAuthor

Thanks@robert-cronin! Sorry for the delay. We will review this soon!

No problems, thanks@pxp928!

@pxp928pxp928 added the needs-reviewNeeds writer LGTM labelJan 6, 2025
Copy link
Contributor

@lumjjblumjjb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This is a super cool addition. I wasn't aware of this dataset but this was a really cool implementation and its such a good example on how to add another data source easily (or at least you made it look easy! - any feedback on how to make this easier would be super great as well, or any particular frictions you had). Thanks so much for yet another great contribution! 🙌

robert-cronin reacted with heart emoji
@robert-cronin
Copy link
CollaboratorAuthor

This is a super cool addition. I wasn't aware of this dataset but this was a really cool implementation and its such a good example on how to add another data source easily (or at least you made it look easy! - any feedback on how to make this easier would be super great as well, or any particular frictions you had). Thanks so much for yet another great contribution! 🙌

Thanks@lumjjb ! I really appreciate your encouraging words 😃 In terms of frictions, I think there are some options for improving the scalability of adding new data sources be they collectors or certifiers. Perhaps one idea is to define a common interface that any collector or certifier must implement and then have a registrar similar to how the backend works today in the spirit of dedpulication. There are also some common logic items in the certifiers/collectors like initialising nats/calling ingestion flow/ emitters etc. Not sure how much of that will be changing in v2.0 but it might be worth looking into

@robert-cronin
Copy link
CollaboratorAuthor

Hello@lumjjb! Your suggestions have been implemented and all outstanding changes addressed. If you have any other suggestions, let me know.

Signed-off-by: robert-cronin <robert.owen.cronin@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@jeffmendozajeffmendozaAwaiting requested review from jeffmendozajeffmendoza is a code owner

@funnelfiascofunnelfiascoAwaiting requested review from funnelfiasco

@lumjjblumjjbAwaiting requested review from lumjjb

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
needs-reviewNeeds writer LGTMsize/XL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[feature] Add support for DataDog's malicious software package dataset
4 participants
@robert-cronin@funnelfiasco@pxp928@lumjjb

[8]ページ先頭

©2009-2025 Movatter.jp