Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Fixes geometry values on created event#71

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
Dylan-DutchAndBold wants to merge3 commits intogrimzy:master
base:master
Choose a base branch
Loading
fromDylan-DutchAndBold:patch-1

Conversation

Dylan-DutchAndBold
Copy link
Contributor

See issue#70

@Dylan-DutchAndBold
Copy link
ContributorAuthor

@grimzy Any idea why the tests fail, looking at it, it might be that model events do not work in tests. I'm trying to run the tests locally but I getClass "\Mockery\Adapter\Phpunit\TestListener" does not implement the PHPUnit\Framework\TestListener interface

Updated event is fired before saved. So to make this work on observers observing the updated event we need to invoke on the updated event instead of the saved event.
@grimzy
Copy link
Owner

@Dylan-DutchAndBold : thank you for the PR.
I'm sorry, I still didn't have time to look at it thoroughly to merge it.

Regarding tests, maybe this will help:https://laravel.com/docs/5.7/mocking#event-fake

@grimzy
Copy link
Owner

grimzy commentedMar 9, 2020•
edited
Loading

Closes#70,#80

@RomainMazB
Copy link

This PR is absolutely needed!

I've tested it in my project and it perfectly solved the geometries issues on save/create events.

For now to implement this I've extended SpatialTrait to create a custom one with this PR's change into its bootTrait method

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Numeric value out of range when inserting
3 participants
@Dylan-DutchAndBold@grimzy@RomainMazB
[8]ページ先頭
©2009-2025 Movatter.jp