Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Laravel 10#206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
limenet wants to merge10 commits intogrimzy:master
base:master
Choose a base branch
Loading
fromlimenet:laravel-10
Open

Laravel 10#206

limenet wants to merge10 commits intogrimzy:masterfromlimenet:laravel-10

Conversation

limenet
Copy link

Core changes:

  • Adds support for Laravel 10
  • Use PHPUnit 10
  • Use namespaces in tests

Packages changes thanks tohttps://github.com/spatie/package-skeleton-laravel:

  • Use GitHub Actions instead of Travis CI
  • Use PHPStan to ensure code quality
  • Use Laravel Pint to fix code style

Some changes may not be required, let me know if/what you'd like me to revert. And thanks for all your work!

limenetand others added10 commitsMarch 12, 2023 11:41
change credsdoctrine/dbalmysql credsbumpmysqlmysql extchange mysqlsleeprun against PRssleepmysqlcall parentuse mysql 8use delta comparisonuse deltadisable fail-fastcleanupdbal conflictfail fast
phpstanFix stylingFix stylingFix styling
Fix stylingFix stylingFix stylingfixup! phpstan
Fix styling
Fix stylingcleanupfix testsFix stylingfix testfix testFix stylingfix testsdebugging tests
@asanikovich
Copy link

@OzanKurt
Copy link

@limenet Can you please publish this pull request as a new package?

This package is not being maintained since 2020.

limenet and AHMADSSGIT2 reacted with thumbs up emoji

@limenet
Copy link
Author

@OzanKurt Normally I'm hesitant to take over a package but as you mentioned, this package appears to be abandoned, so there's a new repository now over athttps://github.com/limenet/laravel-mysql-spatial.

Before I tag a release, could you please give it a try?

  1. Seehttps://github.com/limenet/laravel-mysql-spatial#migration-from-grimzylaravel-mysql-spatial for a (very) short migration guide
  2. Please install the package usingcomposer require limenet/laravel-mysql-spatial:dev-master for now

If you find any issues, please let me knowby opening an issue (or even a pull request!). Thank you!

Compared to this PR, I made a few more changes that shouldn't affect functionality (except for the namespace change mentioned in the README):

  • Changed namespace fromGrimzy\ toLimenet\
  • PHPStan level increased from 6 to 8
  • Suppressed a deprecation notice
  • Used rector to upgrade code
ann-ok reacted with thumbs up emojiOzanKurt reacted with heart emoji

@OzanKurt
Copy link

@limenet I've alsi copied to a custom package for personal use, I've been using some of the functionality that the package offers. I've not had any problems so far.

Your readme looks amazing!

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@limenet@asanikovich@OzanKurt

[8]ページ先頭

©2009-2025 Movatter.jp