Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Use Eloquent builder methods instead of scopes#159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
MatanYadaev wants to merge2 commits intogrimzy:master
base:master
Choose a base branch
Loading
fromMatanYadaev:scopes-to-builder-methods

Conversation

MatanYadaev
Copy link
Contributor

This PR moves the whole scopes to a dedicated builder (which already exists).

This approach presented introduced in the "Dedicated query builders for Eloquent models" blogpost.

@grimzy What do you think about this approach? Do you notice any drawbacks?

Personally, in my own company, we're using only dedicated model builders and there's a lot of benefit from it.
I thought it could be great to have real IDE autocomplete for spatial methods:

namespaceApp\Builders;useGrimzy\LaravelMysqlSpatial\Eloquent\BuilderasSpatialBuilder;useGrimzy\LaravelMysqlSpatial\Types\Point;class UserBuilderextends SpatialBuilder{publicfunctioninRange(Point$point,int$radius)    {$this->distanceSphereValue('location',$point)->having('distance','<',$radius);return$this;    }}

hananbo, aryehbeitz, OhadRon, san4io, and krenor reacted with thumbs up emoji
@MatanYadaevMatanYadaev changed the titleUse builder methods instead of scopesUse Eloquent builder methods instead of scopesNov 5, 2020
@MatanYadaev
Copy link
ContributorAuthor

@grimzy WDYT?

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

1 participant
@MatanYadaev

[8]ページ先頭

©2009-2025 Movatter.jp