- Notifications
You must be signed in to change notification settings - Fork330
Custom spherical radius & SpatialTrait annotations#117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:srid
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Thank you@khooz ! I've been working on adding SRID support in the Also: |
Can I change the base of this PR and work on it? |
Also, feel free totest the |
Sure. Sorry for the late response. I will test that branch too, though applications may be limited since most of the time, sticking to one SRID (no matter which) will give you a fair result in cases such as distance. |
It is adding a parameter for spherical functions for radius, annotates SpatialTrait with PHPDoc blocks, and defaults the earth radius to a more accurate median (down to cm).
It references#91 and#114; it also fails at CI since the more accurate default radius and the nature of new functionality, which I hope can be resolved.