NotificationsYou must be signed in to change notification settings
Fork140
Star521

Exclude unset fields#168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Open

dima-dmytruk23 wants to merge2 commits intographql-python:main

base:main

Choose a base branch

fromdima-dmytruk23:main

Open

Exclude unset fields#168

dima-dmytruk23 wants to merge2 commits intographql-python:mainfromdima-dmytruk23:main

Conversation

Copy link

dima-dmytruk23 commentedApr 25, 2022

Original discussion:graphql-python/graphene-pydantic#75

I usegraphene andgraphene-pydantic libraries.
Code example:
https://gist.github.com/dima-dmytruk23/aaeba0fbc7a539c1f8bf3d0914fce580

The client does not pass the name field, but it is still present in themutation asNone. Input query turns into aUserUpdateInput, which is when the default values are filled in to the dictionary. So then when your code passes the dictionary in to build theUserUpdate, it sets all the fields -- soexclude_unset doesn't exclude anything, since all the fields were in fact set.
I am fairly sure it's not ingraphene-pydantic, though, since that is only responsible for converting to theGrapheneInputObjectType.

I propose to resolve this issue by adding theexclude unset flag to theGraphQLSchema class and use it in thecoerce_input_value function.

exclude unset fields

5d1e8e7

dima-dmytruk23 requested a review fromCito as acode owner

April 25, 2022 16:23

fix deepcopy

2958b1e

Copy link

Member

Cito commentedApr 30, 2022

Hi@dima-dmytruk23, and thanks for contributing.

Please understand that the scope of GraphQL-core is to be a straight-forward port of GraphQL.js, so I am very reluctant to add features that are not part of GraphQL.js or change the API. I'm not saying that we can never do this, and we in fact have serveral such extensions, but you really need to have convincing reasons why this is necessary. Any such extension makes maintaining GraphQL-core and keeping it in sync with GraphQL.js more difficult as they sum up.

Therefore, could you please first open an issue and explain what the feature tries to achieve, and how it could be useful and why it cannot be achieved in other ways, with example code, independent of Graphene or Graphene-Pydantic? We also require unit tests, and this will help to create them.