Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

fix: ci checks#1990

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
saihaj wants to merge6 commits intosource
base:source
Choose a base branch
Loading
fromsaihaj/improve-ci
Open

fix: ci checks#1990

saihaj wants to merge6 commits intosourcefromsaihaj/improve-ci

Conversation

saihaj
Copy link
Member

Noticed the new docs validation job was failing#1983. This PR fixes the syntax and merges all the checks in one job as multiple jobs.

CleanShot 2025-04-28 at 13 11 31@2x
source:https://github.com/graphql/graphql.github.io/actions/runs/14702757073

cc@sarahxsanders

sarahxsanders reacted with eyes emoji
@vercelVercel
Copy link

vercelbot commentedApr 28, 2025•
edited
Loading

The latest updates on your projects. Learn more aboutVercel for Git ↗︎

NameStatusPreviewCommentsUpdated (UTC)
graphql-github-io✅ Ready (Inspect)Visit Preview💬Add feedbackApr 28, 2025 0:22am

@saihaj
Copy link
MemberAuthor

so looks like this one fails because our this CI job can't build the Conf websites since we are missing API keys on GitHub Actions CI.

CleanShot 2025-04-28 at 18 05 52@2x

@sarahxsanders@benjie@Urigo options we have to unblock this

  1. We ignore the/conf/** subpaths since for each conf version we have an API key to build. I am not even sure what the rate limits are so probably a wise idea.
  2. Someone helps me get the API keys (we have these on our vercel) and configure on GitHub CI.

@benjie
Copy link
Member

benjie commentedApr 28, 2025•
edited
Loading

I'd go with option 1 for now, seems thesafest least likely to break CI flows 👍

saihaj and sarahxsanders reacted with thumbs up emoji

@sarahxsanders
Copy link
Contributor

I agree with@benjie

@saihaj
Copy link
MemberAuthor

actually we can't do1 because I can't find a way to ignore building the conf site 🥲

sarahxsanders reacted with eyes emoji

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@saihaj@benjie@sarahxsanders
[8]ページ先頭
©2009-2025 Movatter.jp