- Notifications
You must be signed in to change notification settings - Fork1.8k
[graphiql v4] Allow reassign tab name#3753
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:graphiql-v4
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
changeset-botbot commentedAug 24, 2024 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
🦋 Changeset detectedLatest commit:4ed7cda The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means?Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
codecovbot commentedAug 24, 2024 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@## graphiql-v4 #3753 +/- ##===============================================- Coverage 65.30% 65.19% -0.12%=============================================== Files 121 121 Lines 7006 7021 +15 Branches 2263 2265 +2 ===============================================+ Hits 4575 4577 +2- Misses 2414 2427 +13 Partials 17 17
|
acao commentedAug 24, 2024 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
I see it's still WIP so maybe persistence is already planned, i think we should provide hooks for handling and setting tab name (so for example explorer could change the tab name), but i want to improve the hooks design. we already provide hooks for controlling tabs. we should provide tabs for reading and controlling tab state, including tab name. ideally we could combine some of this into something like there was something else I wanted to reccomend here but i forgot, I'll come back to this, but thanks for all the initiative! |
Uh oh!
There was an error while loading.Please reload this page.
fixes#3608
TODO:
input
to@graphiql/react
Preview