Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings
This repository was archived by the owner on Mar 20, 2023. It is now read-only.

update graphql peerdep#411

Merged
IvanGoncharov merged 3 commits intographql:masterfromgraingert:update-peerdeps
Feb 15, 2018

Conversation

graingert
Copy link
Contributor

This is a fixed version of#407

@IvanGoncharov
Copy link
Member

@graingert Great 👍
Can you also fixnpm test?
Updatingflow-bin will solve all Flow errors.
You also need to update error messages inside tests:
https://travis-ci.org/graphql/express-graphql/jobs/329899395#L827

@graingert
Copy link
ContributorAuthor

Was hoping it would just pass. Will have a fiddle locally

Thomas Grainger added2 commitsJanuary 17, 2018 15:21
This is a fixed version ofgraphql#407also update tests with the new graphql error messages.
@graingert
Copy link
ContributorAuthor

@IvanGoncharov I also had to update eslint.

@graingert
Copy link
ContributorAuthor

@IvanGoncharov can you also have a look at my other PRs:#410#409

@IvanGoncharov
Copy link
Member

@graingert Great 👍
Now we need to wait for someone with commit rights to merge this PR.

@leebyron Can you please take a look?

@IvanGoncharov
Copy link
Member

@leebyron This is super simple PR that just add support for^0.12.0 vesions ofgraphql-js and fix a few test. At the same time it blocks a lot of people including myself from upgrading to the new version ofgraphql.
Can you please take a look?

@IvanGoncharov
Copy link
Member

@leebyron Now that0.13 is published can you please merge this PR and also add0.13 to peerDependencies?

Without this changeexpress-graphql is unusable 😭

@IvanGoncharovIvanGoncharov merged commitc3e48c5 intographql:masterFeb 15, 2018
@IvanGoncharov
Copy link
Member

@graingert Merged 🎉 Thank you for PR and sorry for the delay.
I will try to make release ASAP.

@graingert
Copy link
ContributorAuthor

graingert commentedFeb 15, 2018 via email

Woops this is a bit too late 0.13 came out.
On 15 Feb 2018 15:09, "Ivan Goncharov" ***@***.***> wrote:@graingert <https://github.com/graingert> Merged 🎉 Thank you for PR and sorry for the delay. I will try to make release ASAP. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#411 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAZQTAsllWPNKL02kGzlRYkbxCQol5zQks5tVEiXgaJpZM4RhcCZ> .

@IvanGoncharov
Copy link
Member

@graingert I'm working on it.
I just got commits rights to this repo so I want to make a new release including all simple PRs.

@graingert
Copy link
ContributorAuthor

graingert commentedFeb 15, 2018 via email

Kay
On 15 Feb 2018 23:48, "Ivan Goncharov" ***@***.***> wrote:@graingert <https://github.com/graingert> I'm working on it. I just got commits rights to this repo so I want to make a new release including all simple PRs. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#411 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAZQTH3IIcyLrkIsvdCXEE8bEYzRTyyVks5tVMJigaJpZM4RhcCZ> .

@graingert
Copy link
ContributorAuthor

graingert commentedFeb 15, 2018 via email

Any chance of a graphql monorepo? So versions can be updated and tested inlockstep?
On 15 Feb 2018 23:49, "Thomas Grainger" ***@***.***> wrote: Kay On 15 Feb 2018 23:48, "Ivan Goncharov" ***@***.***> wrote:>@graingert <https://github.com/graingert> I'm working on it.> I just got commits rights to this repo so I want to make a new release> including all simple PRs.>> —> You are receiving this because you were mentioned.> Reply to this email directly, view it on GitHub> <#411 (comment)>,> or mute the thread> <https://github.com/notifications/unsubscribe-auth/AAZQTH3IIcyLrkIsvdCXEE8bEYzRTyyVks5tVMJigaJpZM4RhcCZ>> .>

@IvanGoncharov
Copy link
Member

@graingert It's planned to releasegraphql@14.0.0, so updating peer dependency will be required only after breaking changes:graphql/graphql-js#1005

@IvanGoncharov
Copy link
Member

@graingert 📦v0.6.12 released with support for graphql v0.12.x and v0.13.x.

Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@j0k3rj0k3rj0k3r approved these changes

@IvanGoncharovIvanGoncharovIvanGoncharov approved these changes

Assignees
No one assigned
Labels
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

4 participants
@graingert@IvanGoncharov@j0k3r@facebook-github-bot

[8]ページ先頭

©2009-2025 Movatter.jp