- Notifications
You must be signed in to change notification settings - Fork521
Revert https://github.com/graphql/dataloader/pull/222#386
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Draft
NShahri wants to merge19 commits intographql:mainChoose a base branch fromNShahri:remove-extra-promises
base:main
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
+7,409 −8,419
Draft
Changes from1 commit
Commits
Show all changes
19 commits Select commitHold shift + click to select a range
b0814f9 upgrade packages including eslint, jest and changesets, install types…
NShahri910c937 use tsup to build/watch the package
NShahria454ec2 fix the eslint config and script
NShahrifab2884 fix prettier config
NShahried9862a fix the jest config and enaable ESM for jest
NShahrifaf3fb0 mirate to typescript
NShahrib73bb0b remove not required files like flow,jest,yarn and babel configs
NShahri05c662a refactor: make DataLoader properties private and define move some met…
NShahri6da3bbb Implement custom handler for unhandled promise rejections in Jest tests
NShahri028d3c9 Switch from Yarn to NPM for dependency installation
NShahri9fc234f Update validation workflow name and trigger events
NShahrica45b68 Fix command syntax for running CI tests in validation.yml
NShahri6374f4a use global dependency when DataLoader initiated, refactor tests for e…
NShahri509a351 skip unhandled rejections test
NShahri523fde1 replace tsup with tsdown
NShahrida5bfb8 use Node’s type stripping for development, tsc for build
NShahri67ae31e remove cache hits
NShahri1aa1fba cleanup
NShahri7ca8681 update package.json to correct paths for module exports
NShahriFile filter
Filter by extension
Conversations
Failed to load comments.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Jump to
Jump to file
Failed to load files.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Diff view
Diff view
fix the eslint config and script
- Loading branch information
Uh oh!
There was an error while loading.Please reload this page.
commita454ec2b21eaf100caaed02284e51ecb44bb0f91
There are no files selected for viewing
2 changes: 0 additions & 2 deletions.eslintignore
This file was deleted.
Oops, something went wrong.
Uh oh!
There was an error while loading.Please reload this page.
177 changes: 0 additions & 177 deletions.eslintrc
This file was deleted.
Oops, something went wrong.
Uh oh!
There was an error while loading.Please reload this page.
18 changes: 18 additions & 0 deletionseslint.config.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| import js from '@eslint/js'; | ||
| import globals from 'globals'; | ||
| import tseslint from 'typescript-eslint'; | ||
| import eslintConfigPrettier from 'eslint-config-prettier'; | ||
| import eslintPluginPrettierRecommended from 'eslint-plugin-prettier/recommended'; | ||
| import { defineConfig } from 'eslint/config'; | ||
| export default defineConfig([ | ||
| { | ||
| files: ['**/*.{js,mjs,cjs,ts,mts,cts}'], | ||
| plugins: { js }, | ||
| extends: ['js/recommended'], | ||
| languageOptions: { globals: { ...globals.browser, ...globals.node } }, | ||
| }, | ||
| tseslint.configs.recommended, | ||
| eslintConfigPrettier, | ||
| eslintPluginPrettierRecommended, | ||
| ]); |
6 changes: 1 addition & 5 deletionspackage.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
36 changes: 36 additions & 0 deletionstsconfig.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,36 @@ | ||
| { | ||
| // Visit https://aka.ms/tsconfig to read more about this file | ||
| "compilerOptions": { | ||
| // Environment Settings | ||
| // See also https://aka.ms/tsconfig/module | ||
| "module": "nodenext", | ||
| "target": "esnext", | ||
| "types": ["node"], | ||
| // Other Outputs | ||
| "sourceMap": true, | ||
| "declaration": true, | ||
| "declarationMap": true, | ||
| // Stricter Typechecking Options | ||
| "noUncheckedIndexedAccess": true, | ||
| "exactOptionalPropertyTypes": true, | ||
| // Style Options | ||
| "noImplicitReturns": true, | ||
| "noImplicitOverride": true, | ||
| "noUnusedLocals": true, | ||
| "noUnusedParameters": true, | ||
| "noFallthroughCasesInSwitch": true, | ||
| "noPropertyAccessFromIndexSignature": true, | ||
| // Recommended Options | ||
| "strict": true, | ||
| // "verbatimModuleSyntax": true, | ||
| "isolatedModules": true, | ||
| "noUncheckedSideEffectImports": true, | ||
| "moduleDetection": "force", | ||
| "skipLibCheck": true, | ||
| "allowImportingTsExtensions": true | ||
| } | ||
| } |
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.