- Notifications
You must be signed in to change notification settings - Fork521
Revert https://github.com/graphql/dataloader/pull/222#386
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Draft
NShahri wants to merge13 commits intographql:mainChoose a base branch fromNShahri:remove-extra-promises
base:main
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
…cript and tsup, remove flowbin and babel
…hod as private method in DataLoader
Port DataLoader to TypeScript
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Why#222 Should Be Reverted
In large-scale applications, many resolvers fetch different entities with varying keys and in unpredictable orders. It’s unrealistic to expect all keys for a given entity to be available in the same tick. Designing the batching logic around this assumption leads to brittle behavior and missed optimization opportunities.
This implementation creates new Promise instances—even when they’re not strictly necessary. In large-scale Node.js applications, this can lead to significant performance degradation. Node.js event loop and garbage collector performance drops dramatically when thousands of unresolved promises accumulate.
Batching is an internal optimization detail of the module and should not rely on external timing guarantees. If some keys are waiting to be loaded in the current tick, the module should proactively plan to batch them—even if more keys arrive in the next tick. This ensures consistent and efficient data loading behavior.