- Notifications
You must be signed in to change notification settings - Fork1.9k
Improve ferry instructions#3179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
2445e81 intomaster 3 checks passed
Uh oh!
There was an error while loading.Please reload this page.
OlafFlebbeBosch pushed a commit to OlafFlebbeBosch/graphhopper that referenced this pull requestJul 22, 2025
* announce ferry in instructions* extra instruction sign needed* Update maps to 34acd30e* fix* ensure never NPE* use mode==ferry for mapbox response
karussell added a commit that referenced this pull requestAug 7, 2025
* fix: enable last intersection of last step of via points* fix: accidenteley removed modifier* Improve ferry instructions (#3179)* announce ferry in instructions* extra instruction sign needed* Update maps to 34acd30e* fix* ensure never NPE* use mode==ferry for mapbox response* fix: enable last intersection of last step of via points* fix: typo* fix: depart and arrival at the same last step at end* fix: comment* chore: formatting using editorconfig---------Co-authored-by: Peter <graphhopper@gmx.de>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Explicitly announce if the ferry should be taken and also include info when leaving it.
This PR introduces a new instruction sign. A client should handle this via a fallback that we explicitly documented.
In GraphHopper Maps this will look like this:
(
point=51.010069%2C13.861908&point=51.011743%2C13.864161)