- Notifications
You must be signed in to change notification settings - Fork1.9k
remove block_private and block_fords options#3076
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:car_road_access
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
| "90,-1,algorithm=" +DIJKSTRA_BI, | ||
| "104,-1,algorithm=" +ASTAR_BI, | ||
| "33133,1,ch.disable=true&algorithm=" +DIJKSTRA, | ||
| "22497,1,ch.disable=true&algorithm=" +ASTAR, | ||
| "15434,1,ch.disable=true&algorithm=" +DIJKSTRA_BI, | ||
| "10926,1,ch.disable=true&algorithm=" +ASTAR_BI | ||
| }) |
karussellOct 28, 2024 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
The visited nodes would change with a custom profile that excludes "car_road_access == PRIVATE" too, becauseaccess=customers will be now excluded too. But in general this is more correct and we don't want to separate this from PRIVATE for now. So just change the numbers.
| setEncodedValuesString("car_access, car_average_speed"). | ||
| setProfiles(TestProfiles.accessAndSpeed("profile","car")). | ||
| setEncodedValuesString("car_access, car_average_speed, road_access"). | ||
| setProfiles(carAccessAndPrivateAndSpeed("car")). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
@easbar as the new default forcar_access is without the private exclusion, I would prefer to just adapt the numbers in the tests instead of creating a custom profile like I did here (preliminary) with the private exclusion. Does this make sense for you too?
…s and make xy_access&hgv encoded values more consistent to each other
Uh oh!
There was an error while loading.Please reload this page.
Second try (#2780).
Now based on#3066.
;. Also that we replaced OSMHgvParser with OSMRoadAccessParser.