Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Encode values larger than maxStorableValue as infinity#2990

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Draft
otbutz wants to merge2 commits intographhopper:master
base:master
Choose a base branch
Loading
fromotbutz:overflow_infinity

Conversation

otbutz
Copy link
Contributor

@otbutzotbutz commentedApr 25, 2024
edited
Loading

  • TODO: is this problematic for turn costs?

@karussell
Copy link
Member

The current approach is more conservative. What would be the advantage of this proposal?

@otbutz
Copy link
ContributorAuthor

It's only conservative as long as the maximum value we allow to be encoded exceeds what's relevant for routing decisions.#2987 is an example where this strategy introduces artificial weight limits that are far lower than what is actually tagged in OSM, while the encoded value is still in the range of values relevant to truck routing. Searching for a route with a 26t truck in my case.

Ideally, the EV should be able to cover all "sane" values (see#2989), so that we can ignore values that are either tagging errors like kilograms instead of tonnes, or are far too high for our intended use case.

For example, thisway has a maximum weight limit of 120t. In practice, this is so high that it's irrelevant for any normal vehicle. But by limiting it to the maximum storage value of the EV, we create an artificial limit within the range of values relevant to large trucks.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@otbutz@karussell

[8]ページ先頭

©2009-2025 Movatter.jp