- Notifications
You must be signed in to change notification settings - Fork1.7k
New Highway-Tag based Encoded Values#2977
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Draft
TheDropZone wants to merge2 commits intographhopper:masterChoose a base branch fromTheDropZone:highway-features-encoded
base:master
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Draft
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
… to highway based osm tags
…e config-example.yml file.(cherry picked from commit19aca53)
What are the advantages compared to the |
@karussell Hey! From playing around with the
Currently, I'm trying to set up better tests to really exercise this issue. The ultimate goal is to provide route consumers with the knowledge of where vehicle stop points are on the returned route. |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
High Level Overview
Provide a first pass at adding in
highway
tag based osm data to the options of encoded data.The Goal: To provide traffic signal, stop signs, and traffic crossings back in the routing requests.
The Outcome: The routing API's can provide details on traffic signals, stop signs, and crossing along your route
More Details
The encoded data (tags) being targeted are references in the highway-tag wiki page:highway-tag under the "Other highway features".
Currently, the tags that are being included are
Additionally, this provides a channel to add on additional tags under the
highway
key using this encoded_data tag.This also provides the ability to request those highway features (currently traffic signals, stop signs, and crossing) from the web api via the
details
parameterI attempted to model this after other encoded_value tags and parsers, but am very happy to refactor or adjust as needed. If this data is better loaded using other methods, I am glad to refactor as well. Open to any critiques as this is my first contribution here. Thanks for the time!
Note:
mvn clean test verify
passing locally (and on the new test)