Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

New Highway-Tag based Encoded Values#2977

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Draft
TheDropZone wants to merge2 commits intographhopper:master
base:master
Choose a base branch
Loading
fromTheDropZone:highway-features-encoded

Conversation

TheDropZone
Copy link

@TheDropZoneTheDropZone commentedApr 17, 2024
edited
Loading

High Level Overview

Provide a first pass at adding inhighway tag based osm data to the options of encoded data.
The Goal: To provide traffic signal, stop signs, and traffic crossings back in the routing requests.
The Outcome: The routing API's can provide details on traffic signals, stop signs, and crossing along your route

More Details

The encoded data (tags) being targeted are references in the highway-tag wiki page:highway-tag under the "Other highway features".
Currently, the tags that are being included are

Additionally, this provides a channel to add on additional tags under thehighway key using this encoded_data tag.

graph.encoded_values: highway_feature

This also provides the ability to request those highway features (currently traffic signals, stop signs, and crossing) from the web api via thedetails parameter


I attempted to model this after other encoded_value tags and parsers, but am very happy to refactor or adjust as needed. If this data is better loaded using other methods, I am glad to refactor as well. Open to any critiques as this is my first contribution here. Thanks for the time!


Note:

  • added username and blurb to CONTRIBUTORS.md file
  • tests created and themvn clean test verify passing locally (and on the new test)
  • made an attempt to update the example config, but glad to provide more documentation on this in a different area if there is an apatite.

@TheDropZoneTheDropZone changed the titleNew Highway-Tag based Encoded Values[Draft] New Highway-Tag based Encoded ValuesApr 17, 2024
@TheDropZoneTheDropZone marked this pull request as draftApril 18, 2024 11:32
@TheDropZoneTheDropZone changed the title[Draft] New Highway-Tag based Encoded ValuesNew Highway-Tag based Encoded ValuesApr 18, 2024
@karussell
Copy link
Member

What are the advantages compared to thecrossing encoded value?

@TheDropZone
Copy link
Author

@karussell Hey! From playing around with theCrossing value, I found it got close but 2 issues

  1. It didn't seem to include Stop Signs, though I could be totally wrong there
  2. In true encoded-value fashion, it grouped values together, seemingly removing a lot of information about where the actual crossing was on the edge.

Currently, I'm trying to set up better tests to really exercise this issue. The ultimate goal is to provide route consumers with the knowledge of where vehicle stop points are on the returned route.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@TheDropZone@karussell@bbeiler-ridgeline

[8]ページ先頭

©2009-2025 Movatter.jp