- Notifications
You must be signed in to change notification settings - Fork3.8k
[k102] Backport Remove whole stream deletion mode (#6435)#6477
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
MichelHollands merged 4 commits intografana:k102fromMichelHollands:backport-6435-to-k102Jun 23, 2022
Merged
[k102] Backport Remove whole stream deletion mode (#6435)#6477
MichelHollands merged 4 commits intografana:k102fromMichelHollands:backport-6435-to-k102Jun 23, 2022
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
* Remove whole-stream-deletion modeSigned-off-by: Michel Hollands <michel.hollands@grafana.com>* Remove whole-stream-deletion from docsSigned-off-by: Michel Hollands <michel.hollands@grafana.com>* Update the changelogSigned-off-by: Michel Hollands <michel.hollands@grafana.com>* Sort changelog entriesSigned-off-by: Michel Hollands <michel.hollands@grafana.com>* Remove link to wrong configurationSigned-off-by: Michel Hollands <michel.hollands@grafana.com>* Fix integration testSigned-off-by: Michel Hollands <michel.hollands@grafana.com>* Set default deletion mode to disabledSigned-off-by: Michel Hollands <michel.hollands@grafana.com>* Remove extra white line in documentationSigned-off-by: Michel Hollands <michel.hollands@grafana.com>* Fix default value in docsSigned-off-by: Michel Hollands <michel.hollands@grafana.com>* Fix changelogSigned-off-by: Michel Hollands <michel.hollands@grafana.com>* Add DeletionEnabled method on modeSigned-off-by: Michel Hollands <michel.hollands@grafana.com>* Rename testSigned-off-by: Michel Hollands <michel.hollands@grafana.com>(cherry picked from commitf80e487)
Signed-off-by: Michel Hollands <michel.hollands@grafana.com>
./tools/diff_coverage.sh ../loki-main/test_results.txt test_results.txt ingester,distributor,querier,querier/queryrange,iter,storage,chunkenc,logql,loki Change in test coverage per package. Green indicates 0 or positive change, red indicates that test coverage for a package fell. + ingester0.4%+ distributor0.3%- querier-0.3%- querier/queryrange-0.1%+ iter0%+ storage0%+ chunkenc0%+ logql0.2%- loki-1.2% |
Signed-off-by: Michel Hollands <michel.hollands@grafana.com>
./tools/diff_coverage.sh ../loki-main/test_results.txt test_results.txt ingester,distributor,querier,querier/queryrange,iter,storage,chunkenc,logql,loki Change in test coverage per package. Green indicates 0 or positive change, red indicates that test coverage for a package fell. + ingester0.4%- distributor-0.3%- querier-0.3%+ querier/queryrange0%+ iter0%+ storage0%+ chunkenc0%+ logql0.2%- loki-1.2% |
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHubgit fetch# Create a new branchgit switch --create backport-6477-to-release-2.6.x origin/release-2.6.x# Cherry-pick the merged commit of this pull request and resolve the conflictsgit cherry-pick -x da3fbd965bd4d1f31130dacaa2d1e1dff388321f# Push it to GitHubgit push --set-upstream origin backport-6477-to-release-2.6.xgit switch main# Remove the local backport branchgit branch -D backport-6477-to-release-2.6.x Then, create a pull request where the |
grafanabot pushed a commit that referenced this pull requestJun 24, 2022
* Remove whole stream deletion mode (#6435)* Remove whole-stream-deletion modeSigned-off-by: Michel Hollands <michel.hollands@grafana.com>* Remove whole-stream-deletion from docsSigned-off-by: Michel Hollands <michel.hollands@grafana.com>* Update the changelogSigned-off-by: Michel Hollands <michel.hollands@grafana.com>* Sort changelog entriesSigned-off-by: Michel Hollands <michel.hollands@grafana.com>* Remove link to wrong configurationSigned-off-by: Michel Hollands <michel.hollands@grafana.com>* Fix integration testSigned-off-by: Michel Hollands <michel.hollands@grafana.com>* Set default deletion mode to disabledSigned-off-by: Michel Hollands <michel.hollands@grafana.com>* Remove extra white line in documentationSigned-off-by: Michel Hollands <michel.hollands@grafana.com>* Fix default value in docsSigned-off-by: Michel Hollands <michel.hollands@grafana.com>* Fix changelogSigned-off-by: Michel Hollands <michel.hollands@grafana.com>* Add DeletionEnabled method on modeSigned-off-by: Michel Hollands <michel.hollands@grafana.com>* Rename testSigned-off-by: Michel Hollands <michel.hollands@grafana.com>(cherry picked from commitf80e487)* Fix changelogSigned-off-by: Michel Hollands <michel.hollands@grafana.com>* Fix changelog linkSigned-off-by: Michel Hollands <michel.hollands@grafana.com>(cherry picked from commitda3fbd9)
vlad-diachenko pushed a commit that referenced this pull requestJun 24, 2022
)* Remove whole stream deletion mode (#6435)* Remove whole-stream-deletion modeSigned-off-by: Michel Hollands <michel.hollands@grafana.com>* Remove whole-stream-deletion from docsSigned-off-by: Michel Hollands <michel.hollands@grafana.com>* Update the changelogSigned-off-by: Michel Hollands <michel.hollands@grafana.com>* Sort changelog entriesSigned-off-by: Michel Hollands <michel.hollands@grafana.com>* Remove link to wrong configurationSigned-off-by: Michel Hollands <michel.hollands@grafana.com>* Fix integration testSigned-off-by: Michel Hollands <michel.hollands@grafana.com>* Set default deletion mode to disabledSigned-off-by: Michel Hollands <michel.hollands@grafana.com>* Remove extra white line in documentationSigned-off-by: Michel Hollands <michel.hollands@grafana.com>* Fix default value in docsSigned-off-by: Michel Hollands <michel.hollands@grafana.com>* Fix changelogSigned-off-by: Michel Hollands <michel.hollands@grafana.com>* Add DeletionEnabled method on modeSigned-off-by: Michel Hollands <michel.hollands@grafana.com>* Rename testSigned-off-by: Michel Hollands <michel.hollands@grafana.com>(cherry picked from commitf80e487)* Fix changelogSigned-off-by: Michel Hollands <michel.hollands@grafana.com>* Fix changelog linkSigned-off-by: Michel Hollands <michel.hollands@grafana.com>(cherry picked from commitda3fbd9)Co-authored-by: Michel Hollands <42814411+MichelHollands@users.noreply.github.com>
This was referencedJun 28, 2022
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
backport release-2.6.xTag a PR with this label to create a PR which cherry pics it into the release-2.6.x branch size/Ltype/docsIssues related to technical documentation; the Docs Squad uses this label across many repositories
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Michel Hollandsmichel.hollands@grafana.com
Signed-off-by: Michel Hollandsmichel.hollands@grafana.com
Signed-off-by: Michel Hollandsmichel.hollands@grafana.com
Signed-off-by: Michel Hollandsmichel.hollands@grafana.com
Signed-off-by: Michel Hollandsmichel.hollands@grafana.com
Signed-off-by: Michel Hollandsmichel.hollands@grafana.com
Signed-off-by: Michel Hollandsmichel.hollands@grafana.com
Signed-off-by: Michel Hollandsmichel.hollands@grafana.com
Signed-off-by: Michel Hollandsmichel.hollands@grafana.com
Signed-off-by: Michel Hollandsmichel.hollands@grafana.com
Signed-off-by: Michel Hollandsmichel.hollands@grafana.com
Signed-off-by: Michel Hollandsmichel.hollands@grafana.com
(cherry picked from commitf80e487)
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Checklist
CHANGELOG.md.docs/sources/upgrading/_index.md