- Notifications
You must be signed in to change notification settings - Fork3.8k
Tsdb/index sampling#6329
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Tsdb/index sampling#6329
Uh oh!
There was an error while loading.Please reload this page.
Conversation
./tools/diff_coverage.sh ../loki-main/test_results.txt test_results.txt ingester,distributor,querier,querier/queryrange,iter,storage,chunkenc,logql,loki Change in test coverage per package. Green indicates 0 or positive change, red indicates that test coverage for a package fell. + ingester0%+ distributor0%+ querier0%+ querier/queryrange0%+ iter0%+ storage0%+ chunkenc0%+ logql0%- loki-0.7% |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM
This PR lays the groundwork for index sampling in TSDB. To do so, it creates a new struct,
A set of
(user, from, through, matchers)
will resolve to the approximation of underlyingstreams
,chunks
,bytes
, andentries
.In the short term, this will enable dynamic sharding in the query planner. In the long term, we can expose this as an endpoint and use it to power a host of new features such as cardinality analysis and informing users how much data a query will touch before running it.
There will be a followup PR which wires this into the index-gateway grpc layer.
ref#5428