Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Tsdb/index sampling#6329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
owen-d merged 7 commits intografana:mainfromowen-d:tsdb/index-sampling
Jun 7, 2022
Merged

Conversation

owen-d
Copy link
Member

This PR lays the groundwork for index sampling in TSDB. To do so, it creates a new struct,

typeStatsstruct {Streamsuint64Chunksuint64Bytesuint64Entriesuint64}

A set of(user, from, through, matchers) will resolve to the approximation of underlyingstreams,chunks,bytes, andentries.

In the short term, this will enable dynamic sharding in the query planner. In the long term, we can expose this as an endpoint and use it to power a host of new features such as cardinality analysis and informing users how much data a query will touch before running it.

There will be a followup PR which wires this into the index-gateway grpc layer.

ref#5428

@owen-dowen-d requested a review froma team as acode ownerJune 7, 2022 16:36
@owen-dowen-dforce-pushed thetsdb/index-sampling branch from733b793 tod94388fCompareJune 7, 2022 17:04
@grafanabot
Copy link
Contributor

./tools/diff_coverage.sh ../loki-main/test_results.txt test_results.txt ingester,distributor,querier,querier/queryrange,iter,storage,chunkenc,logql,loki

Change in test coverage per package. Green indicates 0 or positive change, red indicates that test coverage for a package fell.

+           ingester0%+        distributor0%+            querier0%+ querier/queryrange0%+               iter0%+            storage0%+           chunkenc0%+              logql0%-               loki-0.7%

Copy link
Collaborator

@slim-beanslim-bean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@slim-beanslim-beanslim-bean approved these changes

Assignees

No one assigned

Labels

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@owen-d@grafanabot@slim-bean

[8]ページ先頭

©2009-2025 Movatter.jp