Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Addmulti_kv_config block to overrides ConfigMap when multi-kv mode is enabled#6323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

JordanRushing
Copy link
Contributor

Signed-off-by: JordanRushingrushing.jordan@gmail.com

What this PR does / why we need it:
This PR adds a correctly-nestedmulti_kv_config block to the overrides configmap when multi kv mode is enabled to support a migration between Consul and Memberlist.

Which issue(s) this PR fixes:
N/A

Special notes for your reviewer:
N/A

Checklist

  • Documentation added
  • Tests updated
  • Is this an important fix or new feature? Add an entry in theCHANGELOG.md.
  • Changes that require user attention or interaction to upgrade are documented indocs/sources/upgrading/_index.md

…bledSigned-off-by: JordanRushing <rushing.jordan@gmail.com>
@JordanRushingJordanRushing requested a review froma team as acode ownerJune 7, 2022 00:10
@JordanRushingJordanRushing self-assigned thisJun 7, 2022
@JordanRushingJordanRushing changed the titleAdd multi_kv_config block to overrides configmap when multi kv is enabledAddmulti_kv_config block to overrides ConfigMap when multi-kv mode is enabledJun 7, 2022
@grafanabot
Copy link
Contributor

./tools/diff_coverage.sh ../loki-main/test_results.txt test_results.txt ingester,distributor,querier,querier/queryrange,iter,storage,chunkenc,logql,loki

Change in test coverage per package. Green indicates 0 or positive change, red indicates that test coverage for a package fell.

+           ingester0%+        distributor0%+            querier0%+ querier/queryrange0%+               iter0%+            storage0%+           chunkenc0%+              logql0%+               loki0%

Copy link
Collaborator

@trevorwhitneytrevorwhitney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@trevorwhitneytrevorwhitneytrevorwhitney approved these changes

@owen-dowen-dowen-d approved these changes

Assignees

@JordanRushingJordanRushing

Labels

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@JordanRushing@grafanabot@trevorwhitney@owen-d
[8]ページ先頭
©2009-2025 Movatter.jp