- Notifications
You must be signed in to change notification settings - Fork3.8k
copy boltdb-shipper cache changes from PR #6054 to generic index shipper#6316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
copy boltdb-shipper cache changes from PR #6054 to generic index shipper#6316
Uh oh!
There was an error while loading.Please reload this page.
Conversation
./tools/diff_coverage.sh ../loki-main/test_results.txt test_results.txt ingester,distributor,querier,querier/queryrange,iter,storage,chunkenc,logql,loki Change in test coverage per package. Green indicates 0 or positive change, red indicates that test coverage for a package fell. + ingester0%- distributor-0.3%+ querier0%+ querier/queryrange0%+ iter0%+ storage0%+ chunkenc0%+ logql0%+ loki0% |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM
| } | ||
| t.indexSetsMtx.Lock() | ||
| delete(t.indexSets,userID) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This was the cause of the pageLokiBoltdbShipperTablesDownloadFailed that we saw yesterday, we were unexpectedly cleaning up user index set always instead of the one that was broken.
./tools/diff_coverage.sh ../loki-main/test_results.txt test_results.txt ingester,distributor,querier,querier/queryrange,iter,storage,chunkenc,logql,loki Change in test coverage per package. Green indicates 0 or positive change, red indicates that test coverage for a package fell. + ingester0%- distributor-0.3%+ querier0%+ querier/queryrange0%+ iter0%+ storage0%+ chunkenc0%+ logql0%+ loki0% |
./tools/diff_coverage.sh ../loki-main/test_results.txt test_results.txt ingester,distributor,querier,querier/queryrange,iter,storage,chunkenc,logql,loki Change in test coverage per package. Green indicates 0 or positive change, red indicates that test coverage for a package fell. + ingester0%+ distributor0%+ querier0%+ querier/queryrange0%+ iter0%+ storage0%+ chunkenc0%+ logql0%+ loki0% |
What this PR does / why we need it:
I somehow missed porting changes to generic
indexshipperfromboltdb-shippercache changes done in PR#6054. This PR takes care of it.I have also changed the code to drop broken index set earlier instead of just doing it at query time.
Checklist