- Notifications
You must be signed in to change notification settings - Fork3.8k
Add jsonnet tools to build image#6255
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Signed-off-by: Marco Pracucci <marco@pracucci.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM 👍
./tools/diff_coverage.sh ../loki-main/test_results.txt test_results.txt ingester,distributor,querier,querier/queryrange,iter,storage,chunkenc,logql,loki Change in test coverage per package. Green indicates 0 or positive change, red indicates that test coverage for a package fell. + ingester0%+ distributor0%+ querier0%+ querier/queryrange0%+ iter0%+ storage0%+ chunkenc0%+ logql0%+ loki0% |
What this PR does / why we need it:
In#6254 I'm proposing to publish a compiled version of the mixin. To make it run in CI, we need to add some jsonnet tools to build image, which is what I'm doing in this PR. I've bumped the build image minor version (from
0.20to0.21) because I guess you follow semver.Which issue(s) this PR fixes:
N/A
Special notes for your reviewer:
Changes have been tested in#6254
Checklist
CHANGELOG.md.docs/sources/upgrading/_index.md