- Notifications
You must be signed in to change notification settings - Fork3.8k
docs: Fix broken link from unpack parser to pack stage#6207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
and make hyperlinks more obviousSigned-off-by: Christian Haudum <christian.haudum@gmail.com>
./tools/diff_coverage.sh ../loki-main/test_results.txt test_results.txt ingester,distributor,querier,querier/queryrange,iter,storage,chunkenc,logql,loki Change in test coverage per package. Green indicates 0 or positive change, red indicates that test coverage for a package fell. + ingester0%+ distributor0%+ querier0%+ querier/queryrange0%+ iter0%+ storage0%+ chunkenc0%+ logql0%+ loki0% |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM
| ``` | ||
| **Loki 2.2 also includes a new[`unpack`](../../../../logql/log_queries/#unpack) parser to work with the pack stage.** | ||
| **Loki 2.2 also includes a new[`unpack` parser]({{< relref "../../../logql/log_queries.md#unpack" >}}) to work with the pack stage.** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
whyrelref here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
relref is the preferred way to link documents.
First, it throws an error if the linked page does not exist, preventing 404s. And second, it is agostic about how the actual URL of the linked document looks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM
What this PR does / why we need it
before:
after:
