- Notifications
You must be signed in to change notification settings - Fork3.8k
tsdb query fixes#6142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
tsdb query fixes#6142
Uh oh!
There was an error while loading.Please reload this page.
Conversation
./tools/diff_coverage.sh ../loki-main/test_results.txt test_results.txt ingester,distributor,querier,querier/queryrange,iter,storage,chunkenc,logql,loki Change in test coverage per package. Green indicates 0 or positive change, red indicates that test coverage for a package fell. + ingester0%+ distributor0%+ querier0%+ querier/queryrange0%+ iter0%+ storage0%+ chunkenc0%- logql-0.5%+ loki0% |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM!
| func (s*indexShipper)ForEach(ctx context.Context,tableName,userIDstring,callbackfunc(index index.Index)error)error { | ||
| ifs.downloadsManager!=nil { | ||
| returns.downloadsManager.ForEach(ctx,tableName,userID,callback) | ||
| iferr:=s.downloadsManager.ForEach(ctx,tableName,userID,callback);err!=nil { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I thought this was by design: only using either the downloads mgr or the uploads mgr so we didn't query the same indices inR/W mode for the shipper.
| xs:=strings.Split(trimmed,"-") | ||
| iflen(xs)!=2 { | ||
| iflen(xs)<2 { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Nice catch
What this PR does / why we need it:
Doing some minor fixes for the issues that I found on my local setup:
-in their names were failing to be opened.__name__matcher was not removed from queries passed to tsdb head.