- Notifications
You must be signed in to change notification settings - Fork3.8k
do not increment sync operation count metric on per index set#6109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
sandeepsukhani merged 1 commit intografana:mainfromsandeepsukhani:fix-boltdb-shipper-sync-operation-metricMay 6, 2022
Merged
do not increment sync operation count metric on per index set#6109
sandeepsukhani merged 1 commit intografana:mainfromsandeepsukhani:fix-boltdb-shipper-sync-operation-metricMay 6, 2022
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
./tools/diff_coverage.sh ../loki-main/test_results.txt test_results.txt ingester,distributor,querier,querier/queryrange,iter,storage,chunkenc,logql,loki Change in test coverage per package. Green indicates 0 or positive change, red indicates that test coverage for a package fell. + ingester0%+ distributor0%+ querier0%+ querier/queryrange0%+ iter0%+ storage0%+ chunkenc0%+ logql0%+ loki0% |
slim-bean approved these changesMay 6, 2022
sandeepsukhani added a commit that referenced this pull requestMay 6, 2022
sandeepsukhani added a commit that referenced this pull requestMay 6, 2022
This was referencedJun 28, 2022
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Do not increment index sync operation count metric from index set since we already track it on the overall sync operation in table managerhere.
This would also fix unexpected increases in failure counts due to stale index list cache which we handle already by checking if the error is
errIndexListCacheTooStaleand retry the sync.