Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Add query scheduler to "Read Resources" mixin dashboard#6028

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
kavirajk merged 1 commit intomainfromchaudum/loki-mixin-add-query-scheduler
Apr 29, 2022

Conversation

chaudum
Copy link
Contributor

This component has been around for a while but has not been added to the
loki-mixin yet.

Signed-off-by: Christian Haudumchristian.haudum@gmail.com

What this PR does / why we need it:

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Checklist

  • Documentation added
  • Tests updated
  • Is this an important fix or new feature? Add an entry in theCHANGELOG.md.
  • Changes that require user attention or interaction to upgrade are documented indocs/sources/upgrading/_index.md

This component has been around for a while but has not been added to theloki-mixin yet.Signed-off-by: Christian Haudum <christian.haudum@gmail.com>
@chaudumchaudum marked this pull request as ready for reviewApril 26, 2022 14:57
@chaudumchaudum requested a review froma team as acode ownerApril 26, 2022 14:57
Copy link
Contributor

@kavirajkkavirajk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM 👍.

Adding a screenshot or public preview link would be helpful to review PR(s) like this IMHO :)

@chaudum
Copy link
ContributorAuthor

Adding a screenshot or public preview link would be helpful to review PR(s) like this IMHO :)

Agree. Let me install the dashboards locally.

@chaudum
Copy link
ContributorAuthor

@kavirajk Added a screenshot to the PR description.

@chaudumchaudum requested a review fromowen-dApril 27, 2022 15:24
@cyriltovena
Copy link
Contributor

Can we stack CPU and memory graph or that is too much ?

@kavirajk
Copy link
Contributor

@kavirajk Added a screenshot to the PR description.

I don't see it yet. I see it on the other PR though :)https://github.com/grafana/deployment_tools/pull/30245. Feel free to go ahead on merge. It's a non blocker.

@chaudum
Copy link
ContributorAuthor

@kavirajk 🤦 I'm pretty sure I posted it already. Here we go ...
2022-04-27_10-59

kavirajk reacted with heart emoji

@kavirajkkavirajk merged commite2cde40 intomainApr 29, 2022
@kavirajkkavirajk deleted the chaudum/loki-mixin-add-query-scheduler branchApril 29, 2022 09:31
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@owen-dowen-dowen-d approved these changes

+1 more reviewer

@kavirajkkavirajkkavirajk approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@chaudum@cyriltovena@kavirajk@owen-d

[8]ページ先頭

©2009-2025 Movatter.jp