- Notifications
You must be signed in to change notification settings - Fork3.6k
Use embeds for home files in chat examples#952
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
eldondev wants to merge1 commit intogorilla:mainChoose a base branch
base:main
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
+13 −2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Rather than serving up the html files directlyfrom whatever directory the program is run in,embed the files in the binary.
WofWca commentedNov 16, 2024
IDK IDK. It's pretty common for web servers to serve files instead of embedding them in the binary. This IMO complicates the example without a practical benefit. |
ghost commentedNov 28, 2024
Benefits of this change are:
|
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rather than serving up the html files directly
from whatever directory the program is run in,
embed the files in the binary.
What type of PR is this? (check all applicable)
Description
Added/updated tests?
Run verifications and test
make verifyis passingmake testis passing