- Notifications
You must be signed in to change notification settings - Fork69
chore(config): migrate Renovate config#4003
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Summary of ChangesHello@renovate-bot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request performs an automated migration of the Renovate configuration file ( Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on ourdocumentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on@gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign uphere. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with theGemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Code Review
This pull request, generated by Renovate Bot, migrates the Renovate configuration to use newer fields likemanagerFilePatterns andcustom.regex. The migration is generally correct and follows Renovate's new schema. However, I've identified a few pre-existing but now-surfaced issues in the regular expressions for file matching where a literal dot. in a directory name or file extension was not escaped. This could lead to incorrect file matching. I've provided suggestions to fix these patterns for improved correctness.
| "fileMatch": [ | ||
| "^.kokoro/presubmit/graalvm-native.*.cfg$" | ||
| "managerFilePatterns": [ | ||
| "/^.kokoro/presubmit/graalvm-native.*.cfg$/" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
The dots. in the file path.kokoro and file extension.cfg are special characters in regular expressions that match any character. To match literal dots, they should be escaped with a backslash (\.). This ensures the pattern only matches files in the.kokoro directory with a.cfg extension.
| "/^.kokoro/presubmit/graalvm-native.*.cfg$/" | |
| "/^\.kokoro/presubmit/graalvm-native.*\.cfg$/" |
| "fileMatch": [ | ||
| "^.cloudbuild/*" | ||
| "managerFilePatterns": [ | ||
| "/^.cloudbuild/*/" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
The dot. in the file path.cloudbuild is a special character in regular expressions that matches any character. To match a literal dot, it should be escaped with a backslash (\.). This ensures the pattern only matches files in the.cloudbuild directory.
"/^\.cloudbuild/*/| "fileMatch": [ | ||
| "^.cloudbuild/library_generation/library_generation.*\\.Dockerfile$" | ||
| "managerFilePatterns": [ | ||
| "/^.cloudbuild/library_generation/library_generation.*\\.Dockerfile$/" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
The dot. in the file path.cloudbuild is a special character in regular expressions that matches any character. To match a literal dot, it should be escaped with a backslash (\.). This ensures the pattern only matches files in the.cloudbuild directory. Another pattern in this file for the same directory already does this correctly.
"/^\.cloudbuild/library_generation/library_generation.*\.Dockerfile$/"
The Renovate config in this repository needs migrating. Typically this is because one or more configuration options you are using have been renamed.
You don't need to merge this PR right away, because Renovate will continue to migrate these fields internally each time it runs. But later some of these fields may be fully deprecated and the migrations removed. So it's a good idea to merge this migration PR soon.
🔕Ignore: Close this PR and you won't be reminded about config migration again, but one day your current config may no longer be valid.
❓ Got questions? Does something look wrong to you? Please don't hesitate torequest help here.
This PR was generated byMend Renovate. View therepository job log.