- Notifications
You must be signed in to change notification settings - Fork69
chore: add codeowners and repo settings#312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
miraleung suggested changesSep 17, 2020
Contributor
miraleung left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Can we make the owners settings narrower for this repo? Since it's in development, let's start with myself, and we can add to that set as more folks become familiar with this codebase.
ContributorAuthor
JustinBeckwith commentedSep 17, 2020
Sure thing! For which part?
|
Contributor
summer-ji-eng commentedSep 17, 2020
Currently,@miraleung,@summer-ji-eng@xiaozhenliu-gg5 are the main contributors to this repo. |
ContributorAuthor
JustinBeckwith commentedSep 18, 2020
I just yanked any team config to reduce confusion. Feel free to update if/when you like! |
.github/CODEOWNERS Outdated
| # For syntax help see: | ||
| # https://help.github.com/en/github/creating-cloning-and-archiving-repositories/about-code-owners#codeowners-syntax | ||
| * @miraleung, @summer-ji-eng @xiaozhenliu-gg5 |
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
No need comma here.
Contributor
summer-ji-eng commentedSep 19, 2020
Thanks@JustinBeckwith helping us on this. LGTM, wait for@miraleung take another look. |
ContributorAuthor
JustinBeckwith commentedSep 22, 2020
Thanks! Ready for another look@miraleung :) |
suztomo pushed a commit that referenced this pull requestDec 16, 2022
🤖 I have created a release *beep* *boop*---### [2.7.3](googleapis/java-common-protos@v2.7.2...v2.7.3) (2022-02-08)### Dependencies* update dependency com.google.protobuf:protobuf-bom to v3.19.4 ([#309](googleapis/java-common-protos#309)) ([2456122](googleapis/java-common-protos@2456122))* update dependency com.google.protobuf:protobuf-java to v3.19.4 ([#308](googleapis/java-common-protos#308)) ([a0ed177](googleapis/java-common-protos@a0ed177))---This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
suztomo pushed a commit that referenced this pull requestDec 16, 2022
🤖 I have created a release *beep* *boop*---### Updating meta-information for bleeding-edge SNAPSHOT release.---This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
suztomo pushed a commit that referenced this pull requestMar 21, 2023
Fixes#904Source-Author: Neenu Shaji <Neenu1995@users.noreply.github.com>Source-Date: Wed Mar 24 15:50:02 2021 -0400Source-Repo: googleapis/synthtoolSource-Sha: bb854b6c048619e3be4e8b8ce8ed10aa74ea78efSource-Link:googleapis/synthtool@bb854b6
suztomo pushed a commit that referenced this pull requestMar 21, 2023
….0.2 (#312)* deps: update dependency com.google.api.grpc:proto-google-iam-v1 to v1.0.2* bump google.common-protos.version to 2.0.0Co-authored-by: Stephanie Wang <stephaniewang526@users.noreply.github.com>
suztomo pushed a commit that referenced this pull requestMar 21, 2023
🤖 I have created a release \*beep\* \*boop\* ---### [1.93.10](https://www.github.com/googleapis/java-core/compare/v1.93.9...v1.93.10) (2020-10-30)### Dependencies* update core dependencies ([#294](https://www.github.com/googleapis/java-core/issues/294)) ([5f6b784](https://www.github.com/googleapis/java-core/commit/5f6b784ad94b71553d339e3450b17f70dd307e6d))* update core transport dependencies ([#295](https://www.github.com/googleapis/java-core/issues/295)) ([39fdd06](https://www.github.com/googleapis/java-core/commit/39fdd06a84a92c2d314c9de8b1baba0cd5b6589d))* update dependency com.google.api:api-common to v1.10.1 ([#302](https://www.github.com/googleapis/java-core/issues/302)) ([6ebd6b1](https://www.github.com/googleapis/java-core/commit/6ebd6b186dc99bc0a306e2b28150d84c6e6d8125))* update dependency com.google.api.grpc:proto-google-iam-v1 to v1.0.2 ([#312](https://www.github.com/googleapis/java-core/issues/312)) ([e416c1c](https://www.github.com/googleapis/java-core/commit/e416c1cafdafac7165f986194a028096ff936993))* update dependency com.google.guava:guava-bom to v30 ([#310](https://www.github.com/googleapis/java-core/issues/310)) ([1026809](https://www.github.com/googleapis/java-core/commit/1026809177b3460a7170e13cb205b8505bde1ddb))* update dependency io.grpc:grpc-bom to v1.33.0 ([#309](https://www.github.com/googleapis/java-core/issues/309)) ([e021cb0](https://www.github.com/googleapis/java-core/commit/e021cb0943b7b538df79941f98c46cbc53633959))* update dependency org.threeten:threetenbp to v1.4.5 ([#297](https://www.github.com/googleapis/java-core/issues/297)) ([9286f76](https://www.github.com/googleapis/java-core/commit/9286f761449ae51bd7ae4fe84494f9b987a45623))* update dependency org.threeten:threetenbp to v1.5.0 ([#314](https://www.github.com/googleapis/java-core/issues/314)) ([35bcf4d](https://www.github.com/googleapis/java-core/commit/35bcf4d3ff1f47295a466ff37685b7b526af2b1a))---This PR was generated with [Release Please](https://github.com/googleapis/release-please).
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.