This repository was archived by the owner on Sep 21, 2023. It is now read-only.
- Notifications
You must be signed in to change notification settings - Fork4
chore: prevent normalization of semver versioning#41
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
parthea approved these changesApr 16, 2021
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Labels
api: transcoderIssues related to the googleapis/python-video-transcoder API. cla: yesThis human has signed the Contributor License Agreement.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When there is a patch version added to semver versioning, setuptools.setup(version) will normalize the versioning from
-patchto.patchwhich is not correct SEMVER versioning. The added feature with setuptools.sic(version) will prevent this from happening.