This repository was archived by the owner on Sep 21, 2023. It is now read-only.
- Notifications
You must be signed in to change notification settings - Fork4
chore: move samples from GoogleCloudPlatform/python-docs-samples#125
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
snippet-botbot commentedJan 15, 2022 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Here is the summary of changes. You are about to add 16 region tags.
This comment is generated bysnippet-bot.
|
Hi@nicain , Please could you review/approve? |
nicain approved these changesJan 24, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM. Great work!
busunkim96 approved these changesJan 24, 2022
| Next Steps | ||
| ~~~~~~~~~~ | ||
| - See the [Samples](./samples/snippets/README.md). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Nit: this link doesn't seem to show up properly, but feel free to address this in a different PR.
Thanks for moving these here! Please make sure to adjust any references to the samples in the docs published to cloud.google.com before deleting the ones in python-docs-samples. |
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Labels
api: transcoderIssues related to the googleapis/python-video-transcoder API. lang: pythonIssues specific to Python. samplesIssues that are directly related to samples.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> 🦕