Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings
This repository was archived by the owner on Sep 21, 2023. It is now read-only.

chore: use gapic-generator-python 0.58.4#121

Merged
parthea merged 9 commits intomainfromowl-bot-fdf10352-df6e-48cf-a6ce-f3969506dcc1
Feb 15, 2022

Conversation

@gcf-owl-bot
Copy link
Contributor

@gcf-owl-botgcf-owl-botbot commentedDec 31, 2021•
edited by parthea
Loading

  • Regenerate this pull request now.
    fix: rename mapping attribute of AudioStream to mapping_
    fix: resolve issue where mapping attribute of AudioStream could not be set
    fix(deps): require proto-plus >= 1.20.1

committer: dovs
PiperOrigin-RevId: 419025932

Source-Link:googleapis/googleapis@73da669

Source-Link:https://github.com/googleapis/googleapis-gen/commit/46df624a54b9ed47c1a7eefb7a49413cf7b82f98
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNDZkZjYyNGE1NGI5ZWQ0N2MxYTdlZWZiN2E0OTQxM2NmN2I4MmY5OCJ9

BEGIN_COMMIT_OVERRIDE
fix: rename mapping attribute of AudioStream to mapping_

fix: resolve issue where mapping attribute of AudioStream could not be set

fix(deps): require proto-plus >= 1.20.1
END_COMMIT_OVERRIDE

@gcf-owl-botgcf-owl-botbot requested a review froma team as acode ownerDecember 31, 2021 04:00
@trusted-contributions-gcftrusted-contributions-gcfbot added kokoro:force-runAdd this label to force Kokoro to re-run the tests. owlbot:runAdd this label to trigger the Owlbot post processor. labelsDec 31, 2021
@product-auto-labelproduct-auto-labelbot added the api: transcoderIssues related to the googleapis/python-video-transcoder API. labelDec 31, 2021
@gcf-owl-botgcf-owl-botbot removed the owlbot:runAdd this label to trigger the Owlbot post processor. labelDec 31, 2021
@yoshi-kokoroyoshi-kokoro removed the kokoro:force-runAdd this label to force Kokoro to re-run the tests. labelDec 31, 2021
@trusted-contributions-gcftrusted-contributions-gcfbot added kokoro:force-runAdd this label to force Kokoro to re-run the tests. owlbot:runAdd this label to trigger the Owlbot post processor. labelsDec 31, 2021
@gcf-owl-botgcf-owl-botbot removed the owlbot:runAdd this label to trigger the Owlbot post processor. labelDec 31, 2021
@yoshi-kokoroyoshi-kokoro removed the kokoro:force-runAdd this label to force Kokoro to re-run the tests. labelDec 31, 2021
@partheaparthea added kokoro:force-runAdd this label to force Kokoro to re-run the tests. kokoro:runAdd this label to force Kokoro to re-run the tests. labelsDec 31, 2021
@yoshi-kokoroyoshi-kokoro removed kokoro:runAdd this label to force Kokoro to re-run the tests. kokoro:force-runAdd this label to force Kokoro to re-run the tests. labelsDec 31, 2021
@trusted-contributions-gcftrusted-contributions-gcfbot added kokoro:force-runAdd this label to force Kokoro to re-run the tests. owlbot:runAdd this label to trigger the Owlbot post processor. labelsJan 7, 2022
@gcf-owl-botgcf-owl-botbot removed the owlbot:runAdd this label to trigger the Owlbot post processor. labelJan 7, 2022
@gcf-owl-bot
Copy link
ContributorAuthor

Owl bot is regenerating pull request 121...
Build name: NmQyNGQ2MGYtOTdhZC00ZGNjLWI1MzEtZTc0YWY2YTE5MGFk

@gcf-owl-botgcf-owl-botbotforce-pushed theowl-bot-fdf10352-df6e-48cf-a6ce-f3969506dcc1 branch from22e40a9 to8ff513bCompareJanuary 8, 2022 00:49
@trusted-contributions-gcftrusted-contributions-gcfbot added the owlbot:runAdd this label to trigger the Owlbot post processor. labelJan 8, 2022
@gcf-owl-botgcf-owl-botbot removed the owlbot:runAdd this label to trigger the Owlbot post processor. labelJan 8, 2022
@yoshi-kokoroyoshi-kokoro removed the kokoro:force-runAdd this label to force Kokoro to re-run the tests. labelJan 8, 2022
@gcf-owl-bot
Copy link
ContributorAuthor

Owl bot is regenerating pull request 121...
Build name: NDdlYzliMTctZDEwMS00OWMyLThiNTctMDE1NGE2OTgxZGRk

fix: provide appropriate mock values for message body fieldscommitter: dovsPiperOrigin-RevId: 419025932Source-Link:googleapis/googleapis@73da669Source-Link:https://github.com/googleapis/googleapis-gen/commit/46df624a54b9ed47c1a7eefb7a49413cf7b82f98Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNDZkZjYyNGE1NGI5ZWQ0N2MxYTdlZWZiN2E0OTQxM2NmN2I4MmY5OCJ9
@gcf-owl-botgcf-owl-botbotforce-pushed theowl-bot-fdf10352-df6e-48cf-a6ce-f3969506dcc1 branch from4a76da2 to3eff23cCompareJanuary 8, 2022 10:45
@trusted-contributions-gcftrusted-contributions-gcfbot added kokoro:force-runAdd this label to force Kokoro to re-run the tests. owlbot:runAdd this label to trigger the Owlbot post processor. labelsJan 8, 2022
@gcf-owl-botgcf-owl-botbot removed the owlbot:runAdd this label to trigger the Owlbot post processor. labelJan 8, 2022
@trusted-contributions-gcftrusted-contributions-gcfbot added kokoro:force-runAdd this label to force Kokoro to re-run the tests. owlbot:runAdd this label to trigger the Owlbot post processor. labelsFeb 12, 2022
@gcf-owl-botgcf-owl-botbot removed the owlbot:runAdd this label to trigger the Owlbot post processor. labelFeb 12, 2022
@yoshi-kokoroyoshi-kokoro removed the kokoro:force-runAdd this label to force Kokoro to re-run the tests. labelFeb 12, 2022
@trusted-contributions-gcftrusted-contributions-gcfbot added kokoro:force-runAdd this label to force Kokoro to re-run the tests. owlbot:runAdd this label to trigger the Owlbot post processor. labelsFeb 15, 2022
@gcf-owl-botgcf-owl-botbot removed the owlbot:runAdd this label to trigger the Owlbot post processor. labelFeb 15, 2022
@partheaparthea removed the do not mergeIndicates a pull request not ready for merge, due to either quality or timing. labelFeb 15, 2022
@yoshi-kokoroyoshi-kokoro removed the kokoro:force-runAdd this label to force Kokoro to re-run the tests. labelFeb 15, 2022
@trusted-contributions-gcftrusted-contributions-gcfbot added kokoro:force-runAdd this label to force Kokoro to re-run the tests. owlbot:runAdd this label to trigger the Owlbot post processor. labelsFeb 15, 2022
@gcf-owl-botgcf-owl-botbot removed the owlbot:runAdd this label to trigger the Owlbot post processor. labelFeb 15, 2022
@yoshi-kokoroyoshi-kokoro removed the kokoro:force-runAdd this label to force Kokoro to re-run the tests. labelFeb 15, 2022
@partheaparthea added the do not mergeIndicates a pull request not ready for merge, due to either quality or timing. labelFeb 15, 2022
@parthea
Copy link
Contributor

parthea commentedFeb 15, 2022•
edited
Loading

There are 2 tests failing withValueError: Protocol message TextStream has no "mapping" field. however I'm unable to reproduce it locally.

partheniou@partheniou:~/git/python-video-transcoder/samples/snippets$ nox -s py-3.9 -- -k test_create_job_with_embedded_captionsNo user noxfile_config found: detail: No module named 'noxfile_config'nox > Running session py-3.9nox > Creating virtual environment (virtualenv) using python3.9 in .nox/py-3-9nox > python -m pip install -r requirements.txtnox > python -m pip install -r requirements-test.txtnox > pytest --junitxml=sponge_log.xml -k test_create_job_with_embedded_captions=============================================================================================================================== test session starts ================================================================================================================================platform linux -- Python 3.9.9, pytest-6.2.4, py-1.11.0, pluggy-0.13.1rootdir: /usr/local/google/home/partheniou/git/python-video-transcodercollected 11 items / 10 deselected / 1 selected                                                                                                                                                                                                                                    job_test.py .                                                                                                                                                                                                                                                                [100%]-------------------------------------------------------------------------------- generated xml file: /usr/local/google/home/partheniou/git/python-video-transcoder/samples/snippets/sponge_log.xml ---------------------------------------------------------------------------------======================================================================================================================== 1 passed, 10 deselected in 39.61s =========================================================================================================================nox > Session py-3.9 was successful.
partheniou@partheniou:~/git/python-video-transcoder/samples/snippets$ nox -s py-3.9 -- -k test_create_job_with_standalone_captionsNo user noxfile_config found: detail: No module named 'noxfile_config'nox > Running session py-3.9nox > Creating virtual environment (virtualenv) using python3.9 in .nox/py-3-9nox > python -m pip install -r requirements.txtnox > python -m pip install -r requirements-test.txtnox > pytest --junitxml=sponge_log.xml -k test_create_job_with_standalone_captions=============================================================================================================================== test session starts ================================================================================================================================platform linux -- Python 3.9.9, pytest-6.2.4, py-1.11.0, pluggy-0.13.1rootdir: /usr/local/google/home/partheniou/git/python-video-transcodercollected 11 items / 10 deselected / 1 selected                                                                                                                                                                                                                                    job_test.py .                                                                                                                                                                                                                                                                [100%]-------------------------------------------------------------------------------- generated xml file: /usr/local/google/home/partheniou/git/python-video-transcoder/samples/snippets/sponge_log.xml ---------------------------------------------------------------------------------======================================================================================================================== 1 passed, 10 deselected in 39.81s =========================================================================================================================nox > Session py-3.9 was successful.

@parthea
Copy link
Contributor

I've confirmed that the test pass locally. We may need to release a new version to get samples to pass.

partheniou@partheniou:~/git/python-video-transcoder/samples/snippets$ nox -s py-3.9No user noxfile_config found: detail: No module named 'noxfile_config'nox > Running session py-3.9nox > Creating virtual environment (virtualenv) using python3.9 in .nox/py-3-9nox > python -m pip install -r requirements.txtnox > python -m pip install -r requirements-test.txtnox > pytest --junitxml=sponge_log.xml=============================================================================================================================== test session starts ================================================================================================================================platform linux -- Python 3.9.9, pytest-6.2.4, py-1.11.0, pluggy-0.13.1rootdir: /usr/local/google/home/partheniou/git/python-video-transcodercollected 11 items                                                                                                                                                                                                                                                                 job_template_test.py .                                                                                                                                                                                                                                                       [  9%]job_test.py ..........                                                                                                                                                                                                                                                                             [100%]------------------------------------------------------------------------------------------- generated xml file: /usr/local/google/home/partheniou/git/python-video-transcoder/samples/snippets/sponge_log.xml --------------------------------------------------------------------------------------------===================================================================================================================================== 11 passed in 363.64s (0:06:03) =====================================================================================================================================nox > Session py-3.9 was successful.

@partheaparthea added automergeMerge the pull request once unit tests and other checks pass. and removed do not mergeIndicates a pull request not ready for merge, due to either quality or timing. labelsFeb 15, 2022
@partheaparthea merged commitc14695b intomainFeb 15, 2022
@partheaparthea deleted the owl-bot-fdf10352-df6e-48cf-a6ce-f3969506dcc1 branchFebruary 15, 2022 01:49
@gcf-merge-on-greengcf-merge-on-greenbot removed the automergeMerge the pull request once unit tests and other checks pass. labelFeb 15, 2022
@release-pleaserelease-pleasebot mentioned this pull requestFeb 15, 2022
@ipotuzhnov
Copy link

@parthea Thanks a lot for resolving this issue! Our customers will appreciate your work.

parthea reacted with thumbs up emoji

@breogangf
Copy link

@parthea Amazing! Thanks a lot!

parthea reacted with thumbs up emoji

Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.

Reviewers

2 more reviewers

@partheapartheaparthea approved these changes

@ipotuzhnovipotuzhnovipotuzhnov approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: transcoderIssues related to the googleapis/python-video-transcoder API.owl-bot-copy

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@breogangf@busunkim96@ipotuzhnov@parthea@yoshi-kokoro@software-dov
[8]ページ先頭
©2009-2025 Movatter.jp