Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings
This repository was archived by the owner on Feb 1, 2024. It is now read-only.

chore: Repo clean up code snippet that are migrated to python-docs-samples#317

Merged
msampathkumar merged 3 commits intomainfromb_257074671
Dec 7, 2022

Conversation

@msampathkumar
Copy link
Contributor

Repo clean up! Code samples are migrated to python-docs-samples.

For more details, checkhttp://b/257074671

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as abug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@product-auto-labelproduct-auto-labelbot added size: lPull request size is large. api: cloudtasksIssues related to the googleapis/python-tasks API. samplesIssues that are directly related to samples. labelsNov 17, 2022
@conventional-commit-lint-gcf
Copy link

conventional-commit-lint-gcfbot commentedNov 17, 2022•
edited
Loading

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or useautomerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@msampathkumarmsampathkumar changed the titlefeat: Repo clean up - code samples are migrated to python-docs-samplesfeat: Repo clean up code snippet that are migrated to python-docs-samplesNov 17, 2022
@msampathkumarmsampathkumar marked this pull request as ready for reviewNovember 17, 2022 22:37
@snippet-bot
Copy link

snippet-botbot commentedNov 17, 2022•
edited
Loading

Here is the summary of changes.

You are about to delete 5 region tags.

This comment is generated bysnippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, addsnippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@msampathkumarmsampathkumar added the do not mergeIndicates a pull request not ready for merge, due to either quality or timing. labelNov 17, 2022
@msampathkumar
Copy link
ContributorAuthor

A CL for updating docs is in WIP! Added don't merge label for now.

@dandhleedandhlee changed the titlefeat: Repo clean up code snippet that are migrated to python-docs-sampleschore: Repo clean up code snippet that are migrated to python-docs-samplesNov 17, 2022
@dandhlee
Copy link
Contributor

feat,fix ordocs prefix on the PR title triggers a new release on the client library, FYI.

msampathkumar reacted with thumbs up emoji

@product-auto-labelproduct-auto-labelbot added size: xlPull request size is extra large. and removed size: lPull request size is large. labelsNov 18, 2022
@dandhlee
Copy link
Contributor

Please request for a review once snippet-bot check is passing.

@msampathkumar
Copy link
ContributorAuthor

cl/489962491 and cl/492048376 are completed. Rerunning snippet bot checker now!

@dandhleedandhlee added the snippet-bot:force-runForce snippet-bot runs its logic labelDec 1, 2022
@snippet-botsnippet-botbot removed the snippet-bot:force-runForce snippet-bot runs its logic labelDec 1, 2022
Copy link
Contributor

@dandhleedandhlee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Seems like we're deleting more files than we've migrated, can you confirm this is intentional?

# Conflicts:#samples/snippets/noxfile.py
@product-auto-labelproduct-auto-labelbot added size: lPull request size is large. and removed size: xlPull request size is extra large. labelsDec 7, 2022
@msampathkumarmsampathkumar removed the do not mergeIndicates a pull request not ready for merge, due to either quality or timing. labelDec 7, 2022
Copy link
Contributor

@dandhleedandhlee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM, one minor nit.

@dandhleedandhlee added the do not mergeIndicates a pull request not ready for merge, due to either quality or timing. labelDec 7, 2022
@msampathkumarmsampathkumar removed the do not mergeIndicates a pull request not ready for merge, due to either quality or timing. labelDec 7, 2022
@msampathkumarmsampathkumar merged commit376d8c6 intomainDec 7, 2022
@msampathkumarmsampathkumar deleted the b_257074671 branchDecember 7, 2022 20:35
@msampathkumarmsampathkumar restored the b_257074671 branchDecember 7, 2022 20:46
msampathkumar added a commit that referenced this pull requestDec 7, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.

Reviewers

@leahecoleleahecoleAwaiting requested review from leahecoleleahecole was automatically assigned from googleapis/python-samples-reviewers

1 more reviewer

@dandhleedandhleedandhlee approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: cloudtasksIssues related to the googleapis/python-tasks API.samplesIssues that are directly related to samples.size: lPull request size is large.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@msampathkumar@dandhlee
[8]ページ先頭
©2009-2025 Movatter.jp