Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

fix(deps): drop pkg_resources#744

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
parthea merged 1 commit intomainfromdrop-dependency-on-pkg-resources
Mar 30, 2022

Conversation

@parthea
Copy link
Contributor

@partheaparthea commentedMar 30, 2022•
edited
Loading

Fixes#740 🦕

google-cloud-core>=1.6.0 is already listed as a dependency insetup.py. We should remove code that usespkg_resources to checkgoogle-cloud-core>=1.6.0.

"google-cloud-core >= 1.6.0, < 3.0dev",

@partheaparthea requested review froma team ascode ownersMarch 30, 2022 13:32
@product-auto-labelproduct-auto-labelbot added the api: storageIssues related to the googleapis/python-storage API. labelMar 30, 2022
Copy link
Contributor

@cojencocojenco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thank you!

@partheaparthea merged commite963f33 intomainMar 30, 2022
@partheaparthea deleted the drop-dependency-on-pkg-resources branchMarch 30, 2022 23:37
@release-pleaserelease-pleasebot mentioned this pull requestMar 30, 2022
@andrewsg
Copy link
Contributor

Thanks a lot, very helpful!

@release-pleaserelease-pleasebot mentioned this pull requestAug 10, 2022
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@cojencocojencocojenco approved these changes

+1 more reviewer

@busunkim96busunkim96busunkim96 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: storageIssues related to the googleapis/python-storage API.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

addsetuptools to dependencies

4 participants

@parthea@andrewsg@busunkim96@cojenco
[8]ページ先頭
©2009-2025 Movatter.jp