Commit195d644

authored

fix: dont pass credentials to StorageClient (#1608)

if transport is provided with credentials. gRPC client will throw[error](https://github.com/googleapis/python-storage/blob/323cddd5d439e04e12614106eab1928fd4008c0b/google/cloud/_storage_v2/services/storage/client.py#L691-L695)if credentials are passed to client's instance in addition to passing itto transport.

1 parent323cddd commit195d644Copy full SHA for 195d644

File tree

-2

lines changed

-2

lines changed

Lines changed: 0 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -69,7 +69,6 @@ def _create_async_grpc_client(`
`69`	`69`	`transport=transport_cls(credentials=credentials,channel=channel)`
`70`	`70`
`71`	`71`	`returnstorage_v2.StorageAsyncClient(`
`72`		`-credentials=credentials,`
`73`	`72`	`transport=transport,`
`74`	`73`	`client_info=client_info,`
`75`	`74`	`client_options=client_options,`

Lines changed: 0 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -46,7 +46,6 @@ def test_constructor_default_options(self, mock_async_storage_client):`
`46`	`46`	`)`
`47`	`47`	`mock_transport=mock_transport_cls.return_value`
`48`	`48`	`mock_async_storage_client.assert_called_once_with(`
`49`		`-credentials=mock_creds,`
`50`	`49`	`transport=mock_transport,`
`51`	`50`	`client_options=None,`
`52`	`51`	`client_info=None,`

Comments

(0)