Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

fix: set stream_ack_deadline to max_duration_per_lease_extension or 60 s, set ack_deadline to min_duration_per_lease_extension or 10 s#760

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@acocuzzo
Copy link
Contributor

@acocuzzoacocuzzo commentedAug 11, 2022•
edited
Loading

When max_duration_per_lease_extension is set and within the 10 - 600 secs, the stream_ack_deadline will be set to max_duration_per_lease_extension, otherwise it will be set to 60 seconds to match Java client library behavior.

When min_duration_per_lease_extension is set and within the 10 - 600 sec, the ack_deadline will be initialized with this value, otherwise it will default to 10 sec.

Fixes#758🦕

@acocuzzoacocuzzo requested review froma team ascode ownersAugust 11, 2022 00:21
@product-auto-labelproduct-auto-labelbot added size: mPull request size is medium. api: pubsubIssues related to the googleapis/python-pubsub API. labelsAug 11, 2022
@acocuzzoacocuzzo changed the titlefix: set default streaming_ack_deadline to 60 and make configurablefix: set stream_ack_deadline to max_duration_per_lease_extension or 60 s, set ack_deadline to min_duration_per_lease_extension or 10 sAug 11, 2022
@acocuzzoacocuzzo added the owlbot:runAdd this label to trigger the Owlbot post processor. labelAug 11, 2022
@gcf-owl-botgcf-owl-botbot removed the owlbot:runAdd this label to trigger the Owlbot post processor. labelAug 11, 2022
@acocuzzoacocuzzo added the owlbot:runAdd this label to trigger the Owlbot post processor. labelAug 11, 2022
@gcf-owl-botgcf-owl-botbot removed the owlbot:runAdd this label to trigger the Owlbot post processor. labelAug 11, 2022
@acocuzzoacocuzzo merged commit4444129 intogoogleapis:mainAug 11, 2022
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@maheshgattanimaheshgattanimaheshgattani approved these changes

Assignees

No one assigned

Labels

api: pubsubIssues related to the googleapis/python-pubsub API.size: mPull request size is medium.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Set default stream_ack_deadline to 60 sec, or via max_duration_per_lease_extension

2 participants

@acocuzzo@maheshgattani
[8]ページ先頭
©2009-2025 Movatter.jp