Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

chore: bump test coverage to 100%#364

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
plamut merged 7 commits intogoogleapis:masterfromplamut:bump-coverage
Apr 9, 2021

Conversation

@plamut
Copy link
Contributor

@plamutplamut commentedApr 3, 2021•
edited
Loading

Closes#363.
Closes#367.

This PR fixes the code lines/paths that currently drag the overall coverage down.

The majority are error code paths in tests that are never executed if a test passes, and abstract methods that we do not explicitly test if they indeed raiseNotImplementedError. The rest is some unused code and a few other misc. cleanups.

  • Make sure to open an issue as abug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

One of the tests attempted to set an ERROR status on a batch, butthat batch was a mock, meaning that setting a status had no effect.If there was a bug in the corresponding code path, the test wouldprobably not catch it, as that code patch would not be taken.
The tests for flattened arguments to the sync pull() methodhit a code path that emits a deprecation warning, but thatwarning is expected and should not clutter the test output.
@plamutplamut requested a review froma team as acode ownerApril 3, 2021 09:44
@product-auto-labelproduct-auto-labelbot added the api: pubsubIssues related to the googleapis/python-pubsub API. labelApr 3, 2021
@google-clagoogle-clabot added the cla: yesThis human has signed the Contributor License Agreement. labelApr 3, 2021
@tseavertseaver requested a review fromjimfultonApril 5, 2021 18:17
@plamutplamut requested a review fromjimfultonApril 8, 2021 08:16
@plamutplamut merged commit5812018 intogoogleapis:masterApr 9, 2021
@plamutplamut deleted the bump-coverage branchApril 9, 2021 05:53
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

1 more reviewer

@jimfultonjimfultonjimfulton approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: pubsubIssues related to the googleapis/python-pubsub API.cla: yesThis human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

DeprecationWarnings in unit tests should be trapped / asserted Bump required unit test coverage to 100%

2 participants

@plamut@jimfulton
[8]ページ先頭
©2009-2025 Movatter.jp