Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

test: fix streaming pull close test flakiness#361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
plamut merged 2 commits intogoogleapis:masterfromplamut:iss-352
Apr 9, 2021

Conversation

@plamut
Copy link
Contributor

@plamutplamut commentedApr 1, 2021•
edited
Loading

Fixes#352.
Fixes#373.

This PR fixes unit test flakiness by waiting for the streaming pull manager shutdown thread to finish running before making any assertions.

PR checklist

  • Make sure to open an issue as abug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

@plamutplamut requested a review froma team as acode ownerApril 1, 2021 11:16
@product-auto-labelproduct-auto-labelbot added the api: pubsubIssues related to the googleapis/python-pubsub API. labelApr 1, 2021
@google-clagoogle-clabot added the cla: yesThis human has signed the Contributor License Agreement. labelApr 1, 2021
Copy link
Contributor

@jimfultonjimfulton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I'm not sure what flakiness this is fixing.

On my machine, the system testtest_publish_large_messages still fails with a timeout on this branch. Maybe that's not what this PR is intended to address.

@plamut
Copy link
ContributorAuthor

plamut commentedApr 7, 2021•
edited
Loading

@jimfulton It fixes the flakiness inunit tests.

If a system test covering the same code is now flaky, too, we should investigate that as well, but it's a separate issue (that test depends on some assumption about how the backend works).

Edit: Created anissue to track that.

@jimfulton
Copy link
Contributor

@jimfulton It fixes the flakiness inunit tests.

If a system test covering the same code is now flaky, too, we should investigate that as well, but it's a separate issue (that test depends on some assumption about how the backend works).

Oops, OK. :)

@plamutplamut merged commit9f451a1 intogoogleapis:masterApr 9, 2021
@plamutplamut deleted the iss-352 branchApril 9, 2021 13:21
@plamutplamut changed the titlechore: fix streaming pull close test flakinesstest: fix streaming pull close test flakinessMay 7, 2021
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@pradnpradnAwaiting requested review from pradn

1 more reviewer

@jimfultonjimfultonjimfulton approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: pubsubIssues related to the googleapis/python-pubsub API.cla: yesThis human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

3 participants

@plamut@jimfulton@pradn
[8]ページ先頭
©2009-2025 Movatter.jp