NotificationsYou must be signed in to change notification settings
Fork213
Star425

fix: Set timeout to infinite for publishing with ordering keys enabled#1134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

mukund-ananthu merged 1 commit intomainfrominfiniteRetryOrderingEnabled

Apr 4, 2024

Merged

fix: Set timeout to infinite for publishing with ordering keys enabled#1134

mukund-ananthu merged 1 commit intomainfrominfiniteRetryOrderingEnabled

Apr 4, 2024

Conversation

Copy link

Contributor

mukund-ananthu commentedApr 3, 2024•
edited
Loading

Setting timeout to be infinite when publishing with ordering keys enabled.
This is required to retry infinitely when the client library receives retriable error codes from the backend.
Note that there is another testtest_publish_with_ordering_key_with_no_retry that currently does not test the retry behavior or settings because the kwargs forcommit_retry would beNone andcommit_timeout would be_MethodDefault._DEFAULT_VALUE when no retries are specified. This test will be improved in a subsequent PR.

Fixes#1084 🦕

mukund-ananthu requested review froma team ascode owners

April 3, 2024 18:12

product-auto-labelbot added size: xs

Pull request size is extra small.

api: pubsubIssues related to the googleapis/python-pubsub API. labels

Apr 3, 2024

mukund-ananthu force-pushed theinfiniteRetryOrderingEnabled branch fromf8c5928 to302eb45Compare

April 3, 2024 18:20

mukund-ananthu self-assigned this

Apr 3, 2024

mukund-ananthu changed the title~~Set timeout to infinite for publishing with ordering keys enabled~~fix: Set timeout to infinite for publishing with ordering keys enabled

Apr 3, 2024

mukund-ananthu force-pushed theinfiniteRetryOrderingEnabled branch frombc3ce2d toa926ad1Compare

April 3, 2024 19:19

Copy link

conventional-commit-lint-gcfbot commentedApr 3, 2024•
edited
Loading

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or useautomerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/