Commitfcb67dd

authored

fix: add info log for bidi streaming pull ack_deadline requests (#692)

* fix add info logg on bidi streaming pull ack_deadline changes* adding test coverage for logging

1 parent235c313 commitfcb67ddCopy full SHA for fcb67dd

File tree

-1

lines changed

-1

lines changed

Lines changed: 3 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -743,6 +743,9 @@ def heartbeat(self) -> bool:`
`743`	`743`	`request=gapic_types.StreamingPullRequest(`
`744`	`744`	`stream_ack_deadline_seconds=self.ack_deadline`
`745`	`745`	`)`
	`746`	`+_LOGGER.info(`
	`747`	`+"Sending new ack_deadline of %d seconds.",self.ack_deadline`
	`748`	`+ )`
`746`	`749`	`else:`
`747`	`750`	`request=gapic_types.StreamingPullRequest()`
`748`	`751`

Lines changed: 3 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -1035,7 +1035,8 @@ def test_heartbeat_inactive():`
`1035`	`1035`	`assertnotresult`
`1036`	`1036`
`1037`	`1037`
`1038`		`-deftest_heartbeat_stream_ack_deadline_seconds():`
	`1038`	`+deftest_heartbeat_stream_ack_deadline_seconds(caplog):`
	`1039`	`+caplog.set_level(logging.INFO)`
`1039`	`1040`	`manager=make_manager()`
`1040`	`1041`	`manager._rpc=mock.create_autospec(bidi.BidiRpc,instance=True)`
`1041`	`1042`	`manager._rpc.is_active=True`
`@@ -1050,6 +1051,7 @@ def test_heartbeat_stream_ack_deadline_seconds():`
`1050`	`1051`	`assertresult`
`1051`	`1052`	`# Set to false after a send is initiated.`
`1052`	`1053`	`assertnotmanager._send_new_ack_deadline`
	`1054`	`+assert"Sending new ack_deadline of 10 seconds."incaplog.text`
`1053`	`1055`
`1054`	`1056`
`1055`	`1057`	`@mock.patch("google.api_core.bidi.ResumableBidiRpc",autospec=True)`

Comments

(0)