Commit4361e67

authored

fix: batch at most 1,000 ack ids per request (#802)

Co-authored-by: Anna Cocuzzo <63511057+acocuzzo@users.noreply.github.com>Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

1 parentfa23503 commit4361e67Copy full SHA for 4361e67

File tree

-11

lines changed

-11

lines changed

Lines changed: 1 addition & 9 deletions

Original file line number	Diff line number	Diff line change
`@@ -59,16 +59,8 @@`
`59`	`59`	`"""The maximum amount of time in seconds to wait for additional request items`
`60`	`60`	`before processing the next batch of requests."""`
`61`	`61`
`62`		`-_ACK_IDS_BATCH_SIZE=2500`
	`62`	`+_ACK_IDS_BATCH_SIZE=1000`
`63`	`63`	`"""The maximum number of ACK IDs to send in a single StreamingPullRequest.`
`64`		`-`
`65`		`-The backend imposes a maximum request size limit of 524288 bytes (512 KiB) per`
`66`		`-acknowledge / modifyAckDeadline request. ACK IDs have a maximum size of 164`
`67`		`-bytes, thus we cannot send more than o 524288/176 ~= 2979 ACK IDs in a single`
`68`		`-StreamingPullRequest message.`
`69`		`-`
`70`		`-Accounting for some overhead, we should thus only send a maximum of 2500 ACK`
`71`		`-IDs at a time.`
`72`	`64`	`"""`
`73`	`65`
`74`	`66`	`_MIN_EXACTLY_ONCE_DELIVERY_ACK_MODACK_RETRY_DURATION_SECS=1`

Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -437,7 +437,7 @@ def test_ack_splitting_large_payload():`
`437`	`437`	`dispatcher_.ack(items)`
`438`	`438`
`439`	`439`	`calls=manager.send_unary_ack.call_args_list`
`440`		`-assertlen(calls)==3`
	`440`	`+assertlen(calls)==6`
`441`	`441`
`442`	`442`	`all_ack_ids= {item.ack_idforiteminitems}`
`443`	`443`	`sent_ack_ids=collections.Counter()`
`@@ -689,7 +689,7 @@ def test_modify_ack_deadline_splitting_large_payload():`
`689`	`689`	`dispatcher_.modify_ack_deadline(items)`
`690`	`690`
`691`	`691`	`calls=manager.send_unary_modack.call_args_list`
`692`		`-assertlen(calls)==3`
	`692`	`+assertlen(calls)==6`
`693`	`693`
`694`	`694`	`all_ack_ids= {item.ack_idforiteminitems}`
`695`	`695`	`sent_ack_ids=collections.Counter()`

Comments

(0)