Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat: support conversion from pyarrow RecordBatch to pandas DataFrame#39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
tswast merged 10 commits intomainfromissue38-from_arrow
Nov 8, 2021

Conversation

@tswast
Copy link
Collaborator

@tswasttswast commentedNov 3, 2021•
edited
Loading

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as abug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes#38 🦕

@product-auto-labelproduct-auto-labelbot added the api: bigqueryIssues related to the googleapis/python-db-dtypes-pandas API. labelNov 3, 2021
@google-clagoogle-clabot added the cla: yesThis human has signed the Contributor License Agreement. labelNov 3, 2021
@tswasttswast marked this pull request as ready for reviewNovember 4, 2021 15:37
@tswasttswast requested a review froma teamNovember 4, 2021 15:37
@tswasttswast requested a review froma team as acode ownerNovember 4, 2021 15:37
@tswast
Copy link
CollaboratorAuthor

3.10 failure should be resolved by#40

@tswasttswast mentioned this pull requestNov 4, 2021
),
),
]

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Similarly, I'm curious what happens if the PyArrow type istimestamp("ns"), just to cover all possible inputs.

Copy link
CollaboratorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I assume you meanttime64("ns"). I've added a test case, which uncovered a bug in_datetime, which I've fixed.

Copy link

@loferrisloferris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

could perhaps expand testing cases, but LGTM.

@tswasttswast added automergeMerge the pull request once unit tests and other checks pass. and removed automergeMerge the pull request once unit tests and other checks pass. labelsNov 8, 2021
@tswasttswast merged commitfacc7b0 intomainNov 8, 2021
@tswasttswast deleted the issue38-from_arrow branchNovember 8, 2021 22:48
@gcf-merge-on-greengcf-merge-on-greenbot removed the automergeMerge the pull request once unit tests and other checks pass. labelNov 8, 2021
gcf-merge-on-greenbot pushed a commit that referenced this pull requestNov 8, 2021
🤖 I have created a release \*beep\* \*boop\*---## [0.3.0](https://www.github.com/googleapis/python-db-dtypes-pandas/compare/v0.2.0...v0.3.0) (2021-11-08)### Features* support conversion from pyarrow RecordBatch to pandas DataFrame ([#39](https://www.github.com/googleapis/python-db-dtypes-pandas/issues/39)) ([facc7b0](https://www.github.com/googleapis/python-db-dtypes-pandas/commit/facc7b0897e27c5ba99399b7d453818c5b4aeca7))* support Python 3.10 ([#40](https://www.github.com/googleapis/python-db-dtypes-pandas/issues/40)) ([a31d55d](https://www.github.com/googleapis/python-db-dtypes-pandas/commit/a31d55db57b2f5655b1fee4230a930d5bee4b1c9))---This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@stephaniewang526stephaniewang526Awaiting requested review from stephaniewang526

2 more reviewers

@tseavertseavertseaver left review comments

@loferrisloferrisloferris approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: bigqueryIssues related to the googleapis/python-db-dtypes-pandas API.cla: yesThis human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

need__from_arrow__ to supporttypes_mapper

3 participants

@tswast@tseaver@loferris
[8]ページ先頭
©2009-2025 Movatter.jp