Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

fix: avoid rounding problems with microseconds#20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
tswast merged 5 commits intomainfromissue18-divmod
Oct 4, 2021

Conversation

@tswast
Copy link
Collaborator

@tswasttswast commentedSep 30, 2021•
edited
Loading

TODO:

  • More tests with fractional precision
  • Actually fix the failing tests

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as abug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes#18 🦕

@product-auto-labelproduct-auto-labelbot added the api: bigqueryIssues related to the googleapis/python-db-dtypes-pandas API. labelSep 30, 2021
@google-clagoogle-clabot added the cla: yesThis human has signed the Contributor License Agreement. labelSep 30, 2021
@tswasttswast marked this pull request as ready for reviewOctober 4, 2021 17:35
@tswasttswast requested a review froma team as acode ownerOctober 4, 2021 17:35
@tswasttswast requested review froma team andshollyman and removed request fora teamOctober 4, 2021 17:36
@tswasttswast requested a review froma teamOctober 4, 2021 17:42
@tswasttswast merged commit0ff7371 intomainOct 4, 2021
@tswasttswast deleted the issue18-divmod branchOctober 4, 2021 20:58
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@shollymanshollymanAwaiting requested review from shollyman

1 more reviewer

@tseavertseavertseaver approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: bigqueryIssues related to the googleapis/python-db-dtypes-pandas API.cla: yesThis human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

potential rounding error with use ofdivmod

2 participants

@tswast@tseaver
[8]ページ先頭
©2009-2025 Movatter.jp