googleapis/python-cloud-corePublic

NotificationsYou must be signed in to change notification settings
Fork17
Star33

fix!: drop python 2.7 support#103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

tseaver merged 26 commits intomasterfrom102-drop-python-2.7

Aug 2, 2021

Merged

fix!: drop python 2.7 support#103

tseaver merged 26 commits intomasterfrom102-drop-python-2.7

Aug 2, 2021

Conversation

Copy link

Contributor

tseaver commentedJun 15, 2021

Drop use of 'mock' shim.
Drop use of 'six'.
Drop explicit 'u"' prefixes.
Drop 'pytz'.

Release-As: 2.0.0b1

Closes#102.

tseaver requested review frombusunkim96,chrisrossi,crwilcox andjimfulton

June 15, 2021 20:47

tseaver requested a review froma team as acode owner

June 15, 2021 20:47

google-clabot added the cla: yesThis human has signed the Contributor License Agreement. label

Jun 15, 2021

plamut reviewed

Jun 16, 2021

View reviewed changes

Copy link

Contributor

plamut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Generally looks good to me, just a few bits remaining - things from the comments and a few mentions of "Python 2" and "2.7" in the docs that are now obsolete, e.g inCONTRIBUTING.rst and at the end of README.

google/cloud/version.py

		# limitations under the License.

		__version__="1.7.0"
		__version__="2.0.0b1"

Copy link

Contributor

plamutJun 16, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Same process question - should this bebeta or an RC?

Copy link

ContributorAuthor

tseaverJun 16, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

As I said ingoogleapis/python-api-core#212, I think a beta is sensible for a semver-major breaking change. I'll let@crwilcox and@busunkim96 chime in on that.

tests/unit/test__helpers.pyShow resolvedHide resolved

google/cloud/_testing.pyShow resolvedHide resolved

tests/unit/test__helpers.pyShow resolvedHide resolved

plamut reviewed

Jun 17, 2021

View reviewed changes

Copy link

Contributor

plamut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Also update the "Deprecated Python Versions" section in README like in other libraries?

Looks good otherwise, IMO.

Copy link

ContributorAuthor

tseaver commentedJun 18, 2021•
edited
Loading

@plamut Thanks for the review!fca858a updatesREADME.rst to document last version supporting Python 2.7.12014e2 updatesCONTRIBUTING.rst to drop references to running tests under Python 2.7.

tseaver added the do not mergeIndicates a pull request not ready for merge, due to either quality or timing. label

Jun 18, 2021

Copy link

ContributorAuthor

tseaver commentedJun 18, 2021

Marked asdo not merge pending discussion over the versioning policy next week with@busunkim96,@crwilcox, et al.

Copy link

Contributor

plamut commentedJun 18, 2021•
edited
Loading

@tseaver 12014e2 has not been pushed yet? I can still see references to Python 2.7 in CONTRIBUTING when I pull the PR branch locally.

Edit: Ah, the owlbot commit overrode those changes. Was that added to the PR branch involuntarily?

Edit 2 The CONTRIBUTING file is tempalted and must be modified throughowlbot.py to make the changes persistent.

tseaver added10 commits

June 18, 2021 15:32

fix!: drop support for Python 2.7

fa43f54

Release-As: 2.0.0b1Closes#102

fix: drop 'mock' shim

0dd50f0

fix: drop 'six'

a5afb76

fix: drop explicit 'u"' prefix

18ecab3

fix: drop 'pytz'

ac1c294

chore: drop installing 'mock' for unittests

83e0bdc

chore: drop Python2-specific alias

e399f51

docs: note unsupported Python versions

d1c724b

docs: drop references to tests under Python 2.7

91262c0

chore: exclude 'CONTRIBUTING.rst' from sync

85775cc

tseaver force-pushed the102-drop-python-2.7 branch from0862f04 to85775ccCompare

June 18, 2021 19:32

Copy link

ContributorAuthor

tseaver commentedJun 18, 2021

@plamut Owlbot is running in automated fashion, pushing changes to PRs. I guess we have to apply the changes toCONTRIBUTING.rst inowlbot.py vias.replace() (or else exclude it -- see85775cc).

plamut approved these changes

Jun 18, 2021

View reviewed changes

parthea reviewed

Jun 18, 2021

View reviewed changes

CONTRIBUTING.rstShow resolvedHide resolved

tseaverand others added2 commits

June 18, 2021 16:02

chore: revert excluding 'CONTRIBUTING.rst' from sync

5fb81ae

This reverts commit85775cc.

🦉 Updates from OwlBot

fa4dc90

Seehttps://github.com/googleapis/repo-automation-bots/blob/master/packages/owl-bot/README.md

parthea mentioned this pull request

Jun 18, 2021

docs: omit mention of Python 2.7 in 'CONTRIBUTING.rst' (#1127)#105

Closed

chore: bump to latest owlbot image hash

5d468ea

tseaverand others added2 commits

June 18, 2021 18:14

Merge branch '102-drop-python-2.7' of github.com:googleapis/python-cl…

edc214f

…oud-core into 102-drop-python-2.7

🦉 Updates from OwlBot

fa1e188

Seehttps://github.com/googleapis/repo-automation-bots/blob/master/packages/owl-bot/README.md

parthea self-requested a review

July 10, 2021 14:43

tseaverand others added4 commits

July 14, 2021 15:51

Merge branch 'master' into 102-drop-python-2.7

4b7f24b

chore: switch to microgenerator to avoid 2.7 reappearing

e3170d9

Merge branch '102-drop-python-2.7' of github.com:googleapis/python-cl…

dd48c52

…oud-core into 102-drop-python-2.7

🦉 Updates from OwlBot

0e36873

Seehttps://github.com/googleapis/repo-automation-bots/blob/master/packages/owl-bot/README.md

tseaver added the owlbot:runAdd this label to trigger the Owlbot post processor. label

Jul 14, 2021

gcf-owl-botbot removed the owlbot:runAdd this label to trigger the Owlbot post processor. label

Jul 14, 2021

tseaver added the semver: majorHint for users that this is an API breaking change. label

Jul 14, 2021

tseaver added3 commits

July 14, 2021 16:56

chore: expand range to allow 2.x versions of 'google-auth'

277100b

Merge branch 'master' into 102-drop-python-2.7

1ae02ee

Merge branch 'master' into 102-drop-python-2.7

1919c3d

tseaver mentioned this pull request

Jul 27, 2021

chore: release 1.7.2#123

Merged

tseaverand others added4 commits

July 27, 2021 14:02

Merge branch 'master' into 102-drop-python-2.7

48d6e7d

Merge branch 'master' into 102-drop-python-2.7

df37b8f

chore: remove mentions of Python 2.7 from docs

a4b39d0

Except for the README section documentin the last version supporting it.

🦉 Updates from OwlBot

8811785

Seehttps://github.com/googleapis/repo-automation-bots/blob/master/packages/owl-bot/README.md

Copy link

ContributorAuthor

tseaver commentedAug 1, 2021

Ugh, OwlBot is restoring the2.7 reference in the templated `scripts/readme-gen/templates/install_deps.tmpl.rst'. Seegoogleapis/synthtool#1173.

tseaver removed the do not mergeIndicates a pull request not ready for merge, due to either quality or timing. label

Aug 2, 2021

tseaver merged commit181d706 intomaster

Aug 2, 2021

tseaver deleted the 102-drop-python-2.7 branch

August 2, 2021 18:54

This was referencedAug 2, 2021

chore: release 2.0.0b1#126

Merged

chore: release 2.0.0b1#127

Closed

busunkim96 pushed a commit that referenced this pull request

Aug 18, 2021

chore: release 2.0.0 (#133)

1205758

🤖 I have created a release \*beep\* \*boop\*---## [2.0.0](https://www.github.com/googleapis/python-cloud-core/compare/v2.0.0-b1...v2.0.0) (2021-08-18)### ⚠ BREAKING CHANGES* drop python 2.7 support ([#103](https://www.github.com/googleapis/python-cloud-core/issues/103)) ([181d706](https://www.github.com/googleapis/python-cloud-core/commit/181d706e5b44d9d4189c21782551ce85c720d733)), closes [#102](https://www.github.com/googleapis/python-cloud-core/issues/102)### Miscellaneous Chores* trigger 2.0.0 release ([#128](https://www.github.com/googleapis/python-cloud-core/issues/128)) ([aead67a](https://www.github.com/googleapis/python-cloud-core/commit/aead67a1244306d518b8ab150e143e5a29e1ab6f))---This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).